From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <xiang@kernel.org>, <linux-erofs@lists.ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: fix 1 lcluster-sized pcluster for big pcluster
Date: Thu, 13 May 2021 14:54:26 +0800 [thread overview]
Message-ID: <06a646a0-8436-2fd7-4c1b-1d5ea86c600e@huawei.com> (raw)
In-Reply-To: <20210510064715.29123-1-xiang@kernel.org>
On 2021/5/10 14:47, Gao Xiang wrote:
> If the 1st NONHEAD lcluster of a pcluster isn't CBLKCNT lcluster type
> rather than a HEAD or PLAIN type instead, which means its pclustersize
> _must_ be 1 lcluster (since its uncompressed size < 2 lclusters),
> as illustrated below:
>
> HEAD HEAD / PLAIN lcluster type
> ____________ ____________
> |_:__________|_________:__| file data (uncompressed)
> . .
> .____________.
> |____________| pcluster data (compressed)
>
> Such on-disk case was explained before [1] but missed to be handled
> properly in the runtime implementation.
>
> It can be observed if manually generating 1 lcluster-sized pcluster
> with 2 lclusters (thus CBLKCNT doesn't exist.) Let's fix it now.
>
> [1] https://lore.kernel.org/r/20210407043927.10623-1-xiang@kernel.org
> Fixes: cec6e93beadf ("erofs: support parsing big pcluster compress indexes")
> Signed-off-by: Gao Xiang <xiang@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
prev parent reply other threads:[~2021-05-13 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 6:47 [PATCH] erofs: fix 1 lcluster-sized pcluster for big pcluster Gao Xiang
2021-05-13 6:54 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a646a0-8436-2fd7-4c1b-1d5ea86c600e@huawei.com \
--to=yuchao0@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).