linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] erofs: correct indentation of an assigned structure inside a function
@ 2020-01-02 12:02 Vladimir Zapolskiy
  2020-01-02 12:25 ` Gao Xiang
  2020-01-02 12:33 ` Chao Yu
  0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2020-01-02 12:02 UTC (permalink / raw)
  To: Gao Xiang, Chao Yu; +Cc: linux-fsdevel, linux-erofs, Anton Altaparmakov

Trivial change, the expected indentation ruled by the coding style
hasn't been met.

Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
 fs/erofs/xattr.h | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/fs/erofs/xattr.h b/fs/erofs/xattr.h
index 3585b84d2f20..50966f1c676e 100644
--- a/fs/erofs/xattr.h
+++ b/fs/erofs/xattr.h
@@ -46,18 +46,19 @@ extern const struct xattr_handler erofs_xattr_security_handler;
 
 static inline const struct xattr_handler *erofs_xattr_handler(unsigned int idx)
 {
-static const struct xattr_handler *xattr_handler_map[] = {
-	[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
+	static const struct xattr_handler *xattr_handler_map[] = {
+		[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
 #ifdef CONFIG_EROFS_FS_POSIX_ACL
-	[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] = &posix_acl_access_xattr_handler,
-	[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
-		&posix_acl_default_xattr_handler,
+		[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] =
+			&posix_acl_access_xattr_handler,
+		[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
+			&posix_acl_default_xattr_handler,
 #endif
-	[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
+		[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
 #ifdef CONFIG_EROFS_FS_SECURITY
-	[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
+		[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
 #endif
-};
+	};
 
 	return idx && idx < ARRAY_SIZE(xattr_handler_map) ?
 		xattr_handler_map[idx] : NULL;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: correct indentation of an assigned structure inside a function
  2020-01-02 12:02 [PATCH] erofs: correct indentation of an assigned structure inside a function Vladimir Zapolskiy
@ 2020-01-02 12:25 ` Gao Xiang
  2020-01-02 12:33 ` Chao Yu
  1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2020-01-02 12:25 UTC (permalink / raw)
  To: Vladimir Zapolskiy
  Cc: linux-erofs, linux-fsdevel, Gao Xiang, Miao Xie, Anton Altaparmakov

On Thu, Jan 02, 2020 at 02:02:32PM +0200, Vladimir Zapolskiy wrote:
> Trivial change, the expected indentation ruled by the coding style
> hasn't been met.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
> ---
>  fs/erofs/xattr.h | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/erofs/xattr.h b/fs/erofs/xattr.h
> index 3585b84d2f20..50966f1c676e 100644
> --- a/fs/erofs/xattr.h
> +++ b/fs/erofs/xattr.h
> @@ -46,18 +46,19 @@ extern const struct xattr_handler erofs_xattr_security_handler;
>  
>  static inline const struct xattr_handler *erofs_xattr_handler(unsigned int idx)
>  {
> -static const struct xattr_handler *xattr_handler_map[] = {
> -	[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
> +	static const struct xattr_handler *xattr_handler_map[] = {
> +		[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
>  #ifdef CONFIG_EROFS_FS_POSIX_ACL
> -	[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] = &posix_acl_access_xattr_handler,
> -	[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> -		&posix_acl_default_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] =
> +			&posix_acl_access_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> +			&posix_acl_default_xattr_handler,
>  #endif
> -	[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
> +		[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
>  #ifdef CONFIG_EROFS_FS_SECURITY
> -	[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
> +		[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
>  #endif
> -};
> +	};
>  
>  	return idx && idx < ARRAY_SIZE(xattr_handler_map) ?
>  		xattr_handler_map[idx] : NULL;
> -- 
> 2.20.1
>

Thanks, will apply for linux-next.

Thanks,
Gao Xiang


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: correct indentation of an assigned structure inside a function
  2020-01-02 12:02 [PATCH] erofs: correct indentation of an assigned structure inside a function Vladimir Zapolskiy
  2020-01-02 12:25 ` Gao Xiang
@ 2020-01-02 12:33 ` Chao Yu
  1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2020-01-02 12:33 UTC (permalink / raw)
  To: Vladimir Zapolskiy, Gao Xiang, Chao Yu
  Cc: linux-fsdevel, linux-erofs, Anton Altaparmakov

On 2020/1/2 20:02, Vladimir Zapolskiy wrote:
> Trivial change, the expected indentation ruled by the coding style
> hasn't been met.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-02 12:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02 12:02 [PATCH] erofs: correct indentation of an assigned structure inside a function Vladimir Zapolskiy
2020-01-02 12:25 ` Gao Xiang
2020-01-02 12:33 ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).