From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yue Hu <zbestahu@gmail.com>, linux-erofs@lists.ozlabs.org
Cc: sunshijie@xiaomi.com, huyue2@coolpad.com, zhangwen@coolpad.com
Subject: Re: [PATCH 2/2] erofs-utils: fsck: check packed inode only by valid packed_nid
Date: Fri, 2 Jun 2023 17:42:43 +0800 [thread overview]
Message-ID: <0d375b77-36fa-d635-718e-9ec24d39d1b7@linux.alibaba.com> (raw)
In-Reply-To: <ba534c32f9a96d6492917b5bf333d31edc936d31.1685697802.git.huyue2@coolpad.com>
On 2023/6/2 17:37, Yue Hu wrote:
> From: Yue Hu <huyue2@coolpad.com>
>
> Since dedupe feature is also using the same feature bit as fragments.
>
> Fixes: 017f5b402d14 ("erofs-utils: fsck: add a check to packed inode")
> Signed-off-by: Yue Hu <huyue2@coolpad.com>
We should check both
erofs_sb_has_fragments() && sbi.packed_nid > 0 here.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2023-06-02 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 9:37 [PATCH 1/2] erofs-utils: dump: read packed inode only by valid packed_nid Yue Hu
2023-06-02 9:37 ` [PATCH 2/2] erofs-utils: fsck: check " Yue Hu
2023-06-02 9:42 ` Gao Xiang [this message]
2023-06-02 9:43 ` [PATCH 1/2] erofs-utils: dump: read " Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d375b77-36fa-d635-718e-9ec24d39d1b7@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sunshijie@xiaomi.com \
--cc=zbestahu@gmail.com \
--cc=zhangwen@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).