From: kbuild test robot <lkp@intel.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: "Latchesar Ionkov" <lucho@ionkov.net>,
"Hugh Dickins" <hughd@google.com>,
"Mike Marshall" <hubcap@omnibond.com>,
"James Morris" <jmorris@namei.org>,
devel@lists.orangefs.org,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Anna Schumaker" <anna.schumaker@netapp.com>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Mathieu Malaterre" <malat@debian.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kbuild-all@01.org,
"Jan Kara" <jack@suse.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dave Kleikamp" <shaggy@kernel.org>,
linux-doc@vger.kernel.org, "Jeff Layton" <jlayton@kernel.org>,
"Mimi Zohar" <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, "Paul Moore" <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"Eric Sandeen" <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.org,
"Brian Foster" <bfoster@redhat.com>,
reiserfs-devel@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Jaegeuk Kim" <jaegeuk@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>,
"Miklos Szeredi" <miklos@szeredi.hu>,
linux-f2fs-devel@lists.sourceforge.net,
"Benjamin Coddington" <bcodding@redhat.com>,
linux-integrity@vger.kernel.org,
"Martin Brandenburg" <martin@omnibond.com>,
"Chris Mason" <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Vyacheslav Dubeyko" <slava@dubeyko.com>,
"Allison Henderson" <allison.henderson@oracle.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, "Stephen Smalley" <sds@tycho.nsa.gov>,
"Serge Hallyn" <serge@hallyn.com>,
"Eric Paris" <eparis@parisplace.org>,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, samba-technical@lists.samba.org,
linux-xfs@vger.kernel.org, "Bob Peterson" <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net,
"Eric Biggers" <ebiggers@google.com>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Jeff Mahoney" <jeffm@suse.com>,
linux-unionfs@vger.kernel.org,
"David Howells" <dhowells@redhat.com>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Mark Salyzyn" <salyzyn@android.com>,
devel@driverdev.osuosl.org,
"J. Bruce Fields" <bfields@redhat.com>,
"Andreas Gruenbacher" <agruenba@redhat.com>,
"Sage Weil" <sage@redhat.com>,
"Richard Weinberger" <richard@nod.at>,
"Mark Fasheh" <mark@fasheh.com>,
linux-security-module@vger.kernel.org, cluster-devel@redhat.com,
"Steve French" <sfrench@samba.org>,
v9fs-developer@lists.sourceforge.net,
"Bharath Vedartham" <linux.bhar@gmail.com>,
"Jann Horn" <jannh@google.com>,
ecryptfs@vger.kernel.org, "Josef Bacik" <josef@toxicpanda.com>,
"Dave Chinner" <dchinner@redhat.com>,
"David Sterba" <dsterba@suse.com>,
"Artem Bityutskiy" <dedekind1@gmail.com>,
netdev@vger.kernel.org, "Adrian Hunter" <adrian.hunter@intel.com>,
stable@vger.kernel.org, "Tyler Hicks" <tyhicks@canonical.com>,
Ernesto =?unknown-8bit?Q?A=2E_Fern=C3=A1ndez?=
<ernesto.mnd.fernandez@gmail.com>,
"Phillip Lougher" <phillip@squashfs.org.uk>,
"David Woodhouse" <dwmw2@infradead.org>,
linux-btrfs@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 21 Aug 2019 01:43:50 +0800 [thread overview]
Message-ID: <201908210110.Lxwg6dmP%lkp@intel.com> (raw)
In-Reply-To: <20190819183305.153583-1-salyzyn@android.com>
[-- Attachment #1: Type: text/plain, Size: 8044 bytes --]
Hi Mark,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190820]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mark-Salyzyn/Add-flags-option-to-get-xattr-method-paired-to-__vfs_getxattr/20190820-220307
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
security/smack/smack_lsm.c: In function 'smk_fetch':
>> security/smack/smack_lsm.c:308:26: error: 'buffer' undeclared (first use in this function); did you mean 'user'?
skp = smk_import_entry(buffer, rc);
^~~~~~
user
security/smack/smack_lsm.c:308:26: note: each undeclared identifier is reported only once for each function it appears in
--
security/integrity/evm/evm_main.c: In function 'evm_find_protected_xattrs':
>> security/integrity/evm/evm_main.c:103:8: error: 'inode' undeclared (first use in this function)
if (!(inode->i_opflags & IOP_XATTR))
^~~~~
security/integrity/evm/evm_main.c:103:8: note: each undeclared identifier is reported only once for each function it appears in
>> security/integrity/evm/evm_main.c:109:14: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
args.flags = xattr->name;
^
--
In file included from include/linux/stat.h:7:0,
from include/linux/module.h:10,
from fs/9p/acl.c:15:
fs/9p/acl.c: In function 'v9fs_xattr_set_acl':
>> fs/9p/acl.c:258:14: error: 'inode' undeclared (first use in this function)
if (S_ISLNK(inode->i_mode))
^
include/uapi/linux/stat.h:21:23: note: in definition of macro 'S_ISLNK'
#define S_ISLNK(m) (((m) & S_IFMT) == S_IFLNK)
^
fs/9p/acl.c:258:14: note: each undeclared identifier is reported only once for each function it appears in
if (S_ISLNK(inode->i_mode))
^
include/uapi/linux/stat.h:21:23: note: in definition of macro 'S_ISLNK'
#define S_ISLNK(m) (((m) & S_IFMT) == S_IFLNK)
^
--
fs/afs/xattr.c: In function 'afs_xattr_get_cell':
>> fs/afs/xattr.c:334:6: error: 'size' undeclared (first use in this function); did you mean 'ksize'?
if (size == 0)
^~~~
ksize
fs/afs/xattr.c:334:6: note: each undeclared identifier is reported only once for each function it appears in
--
fs/ecryptfs/crypto.c: In function 'ecryptfs_write_metadata_to_xattr':
>> fs/ecryptfs/crypto.c:1131:23: error: 'args' undeclared (first use in this function); did you mean 'abs'?
rc = __vfs_setxattr(&args);
^~~~
abs
fs/ecryptfs/crypto.c:1131:23: note: each undeclared identifier is reported only once for each function it appears in
--
fs/ubifs/xattr.c: In function 'xattr_get':
>> fs/ubifs/xattr.c:676:63: error: 'name' undeclared (first use in this function); did you mean 'page'?
return ubifs_xattr_get(args->inode, xattr_full_name(handler, name),
^~~~
page
fs/ubifs/xattr.c:676:63: note: each undeclared identifier is reported only once for each function it appears in
fs/ubifs/xattr.c: In function 'xattr_set':
>> fs/ubifs/xattr.c:686:6: error: 'value' undeclared (first use in this function); did you mean 'false'?
if (value)
^~~~~
false
fs/ubifs/xattr.c:694:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
fs/ubifs/xattr.c: In function 'xattr_get':
fs/ubifs/xattr.c:678:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
--
fs/xfs/libxfs/xfs_attr.c: In function 'xfs_attr_set':
>> fs/xfs/libxfs/xfs_attr.c:327:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
args.value = value;
^
vim +308 security/smack/smack_lsm.c
d166c8024d620d Casey Schaufler 2014-08-27 271
e114e473771c84 Casey Schaufler 2008-02-04 272 /**
e114e473771c84 Casey Schaufler 2008-02-04 273 * smk_fetch - Fetch the smack label from a file.
1a28979b322bb2 Lukasz Pawelczyk 2014-11-26 274 * @name: type of the label (attribute)
e114e473771c84 Casey Schaufler 2008-02-04 275 * @ip: a pointer to the inode
e114e473771c84 Casey Schaufler 2008-02-04 276 * @dp: a pointer to the dentry
e114e473771c84 Casey Schaufler 2008-02-04 277 *
e774ad683f425a Lukasz Pawelczyk 2015-04-20 278 * Returns a pointer to the master list entry for the Smack label,
e774ad683f425a Lukasz Pawelczyk 2015-04-20 279 * NULL if there was no label to fetch, or an error code.
e114e473771c84 Casey Schaufler 2008-02-04 280 */
2f823ff8bec03a Casey Schaufler 2013-05-22 281 static struct smack_known *smk_fetch(const char *name, struct inode *ip,
2f823ff8bec03a Casey Schaufler 2013-05-22 282 struct dentry *dp)
e114e473771c84 Casey Schaufler 2008-02-04 283 {
e114e473771c84 Casey Schaufler 2008-02-04 284 int rc;
2f823ff8bec03a Casey Schaufler 2013-05-22 285 struct smack_known *skp = NULL;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 286 struct xattr_gs_args args;
e114e473771c84 Casey Schaufler 2008-02-04 287
5d6c31910bc071 Andreas Gruenbacher 2016-09-29 288 if (!(ip->i_opflags & IOP_XATTR))
e774ad683f425a Lukasz Pawelczyk 2015-04-20 289 return ERR_PTR(-EOPNOTSUPP);
e114e473771c84 Casey Schaufler 2008-02-04 290
7d823b0879d4e2 Mark Salyzyn 2019-08-19 291 memset(&args, 0, sizeof(args));
7d823b0879d4e2 Mark Salyzyn 2019-08-19 292 args.dentry = dp;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 293 args.inode = ip;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 294 args.name = name;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 295 args.buffer = kzalloc(SMK_LONGLABEL, GFP_KERNEL);
7d823b0879d4e2 Mark Salyzyn 2019-08-19 296 args.size = SMK_LONGLABEL;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 297 args.flags = XATTR_NOSECURITY;
7d823b0879d4e2 Mark Salyzyn 2019-08-19 298
7d823b0879d4e2 Mark Salyzyn 2019-08-19 299 if (args.buffer == NULL)
e774ad683f425a Lukasz Pawelczyk 2015-04-20 300 return ERR_PTR(-ENOMEM);
e114e473771c84 Casey Schaufler 2008-02-04 301
7d823b0879d4e2 Mark Salyzyn 2019-08-19 302 rc = __vfs_getxattr(&args);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 303 if (rc < 0)
e774ad683f425a Lukasz Pawelczyk 2015-04-20 304 skp = ERR_PTR(rc);
e774ad683f425a Lukasz Pawelczyk 2015-04-20 305 else if (rc == 0)
e774ad683f425a Lukasz Pawelczyk 2015-04-20 306 skp = NULL;
e774ad683f425a Lukasz Pawelczyk 2015-04-20 307 else
2f823ff8bec03a Casey Schaufler 2013-05-22 @308 skp = smk_import_entry(buffer, rc);
f7112e6c9abf1c Casey Schaufler 2012-05-06 309
f7112e6c9abf1c Casey Schaufler 2012-05-06 310 kfree(buffer);
f7112e6c9abf1c Casey Schaufler 2012-05-06 311
2f823ff8bec03a Casey Schaufler 2013-05-22 312 return skp;
e114e473771c84 Casey Schaufler 2008-02-04 313 }
e114e473771c84 Casey Schaufler 2008-02-04 314
:::::: The code at line 308 was first introduced by commit
:::::: 2f823ff8bec03a1e6f9e11fd0c4d54e4c7d09532 Smack: Improve access check performance
:::::: TO: Casey Schaufler <casey@schaufler-ca.com>
:::::: CC: Casey Schaufler <casey@schaufler-ca.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69452 bytes --]
prev parent reply other threads:[~2019-08-21 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 18:32 [PATCH v5] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-erofs
2019-08-20 15:12 ` kbuild test robot
2019-08-20 17:43 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908210110.Lxwg6dmP%lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allison.henderson@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=asmadeus@codewreck.org \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=bfoster@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=dchinner@redhat.com \
--cc=dedekind1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@google.com \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=ericvh@gmail.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jannh@google.com \
--cc=jeffm@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@android.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=sage@redhat.com \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=sandeen@sandeen.net \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=slava@dubeyko.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).