From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: linux-erofs@lists.ozlabs.org, xiang@kernel.org, miaoxie@huawei.com
Subject: Re: [bug report] staging: erofs: introduce erofs_grab_bio
Date: Wed, 28 Aug 2019 15:11:44 +0300 [thread overview]
Message-ID: <20190828121143.GC8372@kadam> (raw)
In-Reply-To: <20190828113929.GA68628@architecture4>
On Wed, Aug 28, 2019 at 07:39:29PM +0800, Gao Xiang wrote:
> (p.s. It makes me little confused these subject prefixes are "[bug report]", if they are
> really bugs, that is fine... If it be something unconfirmed (need our confirmation..,),
> could you kindly change the prefix into some other representations...? I will still look
> into all of them at least... and that makes me feel a bit better and easy.... thanks...)
Of course I thought it *was* a bug...
I've sent probably 1800 of these emails. It's a script but I look over
the email before sending. Maybe when people start using the Link: tag
I will be able to make these show up as reply to an email.
Normally, I sent them out in a much more timely sort of way but all the
erofs warnings show up as new with the move out of staging so I have
been re-reviewing the warnings.
So last August when this code was new, I must have seen the warning but
read the code correctly. I checked before I sent this email to make
sure we hadn't discusssed it before.
But this time I got confused by the DBG_BUGON(). I decided to treat it
as a no-op because it can be configured to do nothing if you have
CONFIG_EROFS_FS_DEBUG disabled. Plus it has "DBG" in the name so it
felt like debug code. But I ended up focussing on it instead of seeing
the "(nofail ? __GFP_NOFAIL : 0)" bit. The DBG_BUGON() is unreachable
and misleading nonsense fluff. :(
regards,
dan carpenter
next prev parent reply other threads:[~2019-08-28 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 10:55 [bug report] staging: erofs: introduce erofs_grab_bio Dan Carpenter
2019-08-28 11:02 ` Gao Xiang
2019-08-28 11:36 ` Dan Carpenter
2019-08-28 11:40 ` Gao Xiang
2019-08-28 11:39 ` Gao Xiang
2019-08-28 12:11 ` Dan Carpenter [this message]
2019-08-28 12:22 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828121143.GC8372@kadam \
--to=dan.carpenter@oracle.com \
--cc=gaoxiang25@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=miaoxie@huawei.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).