From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] staging: erofs: using switch-case while checking the inode type.
Date: Thu, 29 Aug 2019 18:04:36 +0300 [thread overview]
Message-ID: <20190829150436.GI23584@kadam> (raw)
In-Reply-To: <20190829141522.GA15562@architecture4>
On Thu, Aug 29, 2019 at 10:15:22PM +0800, Gao Xiang wrote:
> I am very happy that you send a patch about this, but we have
> to take care of handling "fall through" properly at least,
> and I don't want to introduce some extra compile warnings
> instead at this time.
I can't apply the patch so I maybe missed something. I don't see
a fall through issue. We have the code so you could use ^^^^^^^^ to
indicate which lines have a fall through problem.
>
> EROFS is sensitive for now and I have no idea what the "real"
> point is.
What does "sensitive" mean here? Now that it's out of staging we
aren't applying clean up patches?
regards,
dan carpenter
next prev parent reply other threads:[~2019-08-29 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 13:08 [PATCH] staging: erofs: using switch-case while checking the inode type Pratik Shinde
2019-08-29 13:56 ` Gao Xiang
2019-08-29 14:05 ` Pratik Shinde
2019-08-29 14:15 ` Gao Xiang
2019-08-29 15:04 ` Dan Carpenter [this message]
2019-08-29 15:13 ` Gao Xiang
2019-08-29 18:57 ` Gao Xiang via Linux-erofs
2019-08-29 15:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829150436.GI23584@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).