Linux-EROFS Archive on lore.kernel.org
 help / color / Atom feed
From: Gao Xiang <gaoxiang25@huawei.com>
To: Haruue Icymoon <i@haruue.moe>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fix configure.ac
Date: Fri, 22 Nov 2019 17:35:30 +0800
Message-ID: <20191122093529.GA106418@architecture4> (raw)
In-Reply-To: <20191122085859.GA2414688@usamimi.host.haruue.net>

Hi Haruue,

On Fri, Nov 22, 2019 at 04:58:59PM +0800, Haruue Icymoon wrote:
> ./configure will fail when --with-lz4-libdir is not set, since
> $with_lz4_libdir will be an empty string and generate an empty -L
> into LDFLAGS. This patch fixes it.
> 
> Signed-off-by: Haruue Icymoon <i@haruue.moe>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f925358..870dfb9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -174,7 +174,7 @@ if test "x$enable_lz4" = "xyes"; then
>  
>    if test "x${have_lz4h}" = "xyes" ; then
>      saved_LDFLAGS=${LDFLAGS}
> -    LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
> +    test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
>      AC_CHECK_LIB(lz4, LZ4_compress_destSize, [
>        have_lz4="yes"
>        have_lz4hc="yes"
> -- 
> 2.24.0

Thanks for your patch. *thumb*

Applied to experimental branch now, and I will move it to dev branch
tomorrow since it's a useful trivial build fix for some debian builds
as well [1].

[1] https://buildd.debian.org/status/package.php?p=erofs-utils
    https://buildd.debian.org/status/fetch.php?pkg=erofs-utils&arch=hppa&ver=1.0-3&stamp=1573917897&raw=0

Thanks,
Gao Xiang

> 
> 
> -- 
> Haruue Icymoon
> GPG: E16D 3FA4 E636 A602 2684  0D38 A54A 7E9C 812E EB09
> https://haruue.moe/
> 

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22  8:58 Haruue Icymoon
2019-11-22  9:35 ` Gao Xiang [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122093529.GA106418@architecture4 \
    --to=gaoxiang25@huawei.com \
    --cc=i@haruue.moe \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \
		linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git