From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2XOf=2D=lists.ozlabs.org=linux-erofs-bounces+linux-erofs=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCF2C43603
	for <linux-erofs@archiver.kernel.org>; Fri, 13 Dec 2019 07:25:03 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 495B722527
	for <linux-erofs@archiver.kernel.org>; Fri, 13 Dec 2019 07:25:03 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 495B722527
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org
Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	by lists.ozlabs.org (Postfix) with ESMTP id 47Z2Hd4vNCzDr9S
	for <linux-erofs@archiver.kernel.org>; Fri, 13 Dec 2019 18:25:01 +1100 (AEDT)
Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized)
 smtp.mailfrom=huawei.com (client-ip=45.249.212.189; helo=huawei.com;
 envelope-from=gaoxiang25@huawei.com; receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org;
 dmarc=none (p=none dis=none) header.from=huawei.com
Received: from huawei.com (szxga03-in.huawei.com [45.249.212.189])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 47Z2HT6cXrzDqC9
 for <linux-erofs@lists.ozlabs.org>; Fri, 13 Dec 2019 18:24:53 +1100 (AEDT)
Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57])
 by Forcepoint Email with ESMTP id C1E7F95770885D5B753C
 for <linux-erofs@lists.ozlabs.org>; Fri, 13 Dec 2019 15:24:46 +0800 (CST)
Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by
 DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Fri, 13 Dec 2019 15:24:46 +0800
Received: from architecture4 (10.160.196.180) by
 dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.1713.5; Fri, 13 Dec 2019 15:24:45 +0800
Date: Fri, 13 Dec 2019 15:24:42 +0800
From: Gao Xiang <gaoxiang25@huawei.com>
To: Pratik Shinde <pratikshinde320@gmail.com>
Subject: Re: [RFC] erofs-utils:code for detecting and tracking holes in
 uncompressed sparse files.
Message-ID: <20191213072442.GA111839@architecture4>
References: <20191203140250.23793-1-pratikshinde320@gmail.com>
 <20191204022734.GA60329@architecture4>
 <CAGu0czSNv--LQwrWXuzuT6S5BYs+tnCA8vqAREv7+Z4rEBdtsg@mail.gmail.com>
 <20191209071815.GA144654@architecture4>
 <20191211054917.GA28738@architecture4>
 <CAGu0czQ3wM_1TvwLmuMxtmnqr8yrCgngsmkocp8z3MztAqRL6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAGu0czQ3wM_1TvwLmuMxtmnqr8yrCgngsmkocp8z3MztAqRL6g@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Originating-IP: [10.160.196.180]
X-ClientProxiedBy: dggeme713-chm.china.huawei.com (10.1.199.109) To
 dggeme762-chm.china.huawei.com (10.3.19.108)
X-CFilter-Loop: Reflected
X-BeenThere: linux-erofs@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development of Linux EROFS file system <linux-erofs.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linux-erofs>,
 <mailto:linux-erofs-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linux-erofs/>
List-Post: <mailto:linux-erofs@lists.ozlabs.org>
List-Help: <mailto:linux-erofs-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linux-erofs>,
 <mailto:linux-erofs-request@lists.ozlabs.org?subject=subscribe>
Cc: linux-erofs@lists.ozlabs.org, miaoxie@huawei.com
Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org
Sender: "Linux-erofs"
 <linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org>

On Fri, Dec 13, 2019 at 12:35:00PM +0530, Pratik Shinde wrote:
> Gao,
> 
> just returned from holidays. Let me rethink about this approach.

Okay, no problem at all. :)

Thanks,
Gao Xiang

> 
> --Pratik
> 
> 
> On Wed, Dec 11, 2019, 11:14 AM Gao Xiang <gaoxiang25@huawei.com> wrote:
> 
> > On Mon, Dec 09, 2019 at 03:18:17PM +0800, Gao Xiang wrote:
> > > Hi Pratik,
> > >
> > > On Mon, Dec 09, 2019 at 12:34:50PM +0530, Pratik Shinde wrote:
> > > > Hello Gao,
> > > >
> > > > Did you get any chance to look at this in detail.
> > >
> > > I looked into your implementation weeks before.
> > >
> > > As my reply in the previous email, did you see it and could you check it
> > out?
> > >
> > > Kernel emails are not top-posting so you could scroll down to the end.
> > >
> > > > > "variable-sized inode" isn't a problem here, which can be handled
> > > > > similar to the case of "compress indexes".
> > > > >
> > > > > Probably no need to write linked list to the disk but generate
> > linked list
> > > > > in memory when writing data on the fly, and then transfer to a
> > > > > variable-sized
> > > > > extent array at the time of writing inode metadata (The order is
> > firstly
> > > > > data
> > > > > and then metadata in erofs-utils so it looks practical.)
> >
> >
> > Some feedback words here? Do you think it is unnecessary to use such
> > array for limited fragmented holes (either in-memory or ondisk) as well?
> >
> > Thanks,
> > Gao Xiang
> >
> >
> > >
> > > Thanks,
> > > Gao Xiang
> > >
> > > >
> > > > --Pratik.
> > > >
> > > > On Wed, Dec 4, 2019, 7:52 AM Gao Xiang <gaoxiang25@huawei.com> wrote:
> > > >
> > > > > Hi Pratik,
> > > > >
> > > > > I'll give detailed words this weekend if you have more questions
> > > > > since I'm busying in other stupid intra-company stuffs now...
> > > > >
> > > > > On Tue, Dec 03, 2019 at 07:32:50PM +0530, Pratik Shinde wrote:
> > > > > > NOTE: The patch is not fully complete yet, with this patch I just
> > want to
> > > > > > present rough idea of what I am trying to achieve.
> > > > > >
> > > > > > The patch does following :
> > > > > > 1) Detect holes (of size EROFS_BLKSIZ) in uncompressed files.
> > > > > > 2) Keep track of holes per file.
> > > > > >
> > > > > > In-order to track holes, I used an array of size = (file_size /
> > > > > blocksize)
> > > > > > The array basically tracks number of holes before a particular
> > logical
> > > > > file block.
> > > > > > e.g blks[i] = 10 meaning ith block has 10 holes before it.
> > > > > > If a particular block is a hole we set the index to '-1'.
> > > > > >
> > > > > > how read logic will change:
> > > > > > 1) currently we simply map read offset to a fs block.
> > > > > > 2) with holes in place the calculation of block number would be:
> > > > > >
> > > > > >    blkno = start_block + (offset >> block_size_shift) - (number of
> > > > > >                                                        holes before
> > > > > block in which offset falls)
> > > > > >
> > > > > > 3) If a read offset falls inside a hole (which can be found using
> > above
> > > > > array). We
> > > > > >    fill the user buffer with '\0' on the fly.
> > > > > >
> > > > > > through this,block no. lookup would still be performed in constant
> > time.
> > > > > >
> > > > > > The biggest problem with this approach is - we have to store the
> > hole
> > > > > tracking
> > > > > > array for every file to the disk.Which doesn't seems to be
> > practical.we
> > > > > can use a linkedlist,
> > > > > > but that will make size of inode variable.
> > > > >
> > > > > "variable-sized inode" isn't a problem here, which can be handled
> > > > > similar to the case of "compress indexes".
> > > > >
> > > > > Probably no need to write linked list to the disk but generate
> > linked list
> > > > > in memory when writing data on the fly, and then transfer to a
> > > > > variable-sized
> > > > > extent array at the time of writing inode metadata (The order is
> > firstly
> > > > > data
> > > > > and then metadata in erofs-utils so it looks practical.)
> > > > >
> > > > > Thanks,
> > > > > Gao Xiang
> > > > >
> > > > > >
> > > > > > Signed-off-by: Pratik Shinde <pratikshinde320@gmail.com>
> > > > > > ---
> > > > > >  lib/inode.c | 67
> > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > > > > >  1 file changed, 66 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/lib/inode.c b/lib/inode.c
> > > > > > index 0e19b11..af31949 100644
> > > > > > --- a/lib/inode.c
> > > > > > +++ b/lib/inode.c
> > > > > > @@ -38,6 +38,61 @@ static unsigned char erofs_type_by_mode[S_IFMT
> > >>
> > > > > S_SHIFT] = {
> > > > > >
> > > > > >  struct list_head inode_hashtable[NR_INODE_HASHTABLE];
> > > > > >
> > > > > > +
> > > > > > +#define IS_HOLE(start, end) (roundup(start, EROFS_BLKSIZ) ==
> > start &&
> > > > >       \
> > > > > > +                          roundup(end, EROFS_BLKSIZ) == end &&
> >    \
> > > > > > +                         (end - start) % EROFS_BLKSIZ == 0)
> > > > > > +#define HOLE_BLK             -1
> > > > > > +unsigned int erofs_detect_holes(struct erofs_inode *inode, int
> > *blks)
> > > > > > +{
> > > > > > +     int i, fd, st, en;
> > > > > > +     unsigned int nblocks;
> > > > > > +     erofs_off_t data, hole, len;
> > > > > > +
> > > > > > +     nblocks = inode->i_size / EROFS_BLKSIZ;
> > > > > > +     for (i = 0; i < nblocks; i++)
> > > > > > +             blks[i] = 0;
> > > > > > +     fd = open(inode->i_srcpath, O_RDONLY);
> > > > > > +     if (fd < 0) {
> > > > > > +             return -errno;
> > > > > > +     }
> > > > > > +     len = lseek(fd, 0, SEEK_END);
> > > > > > +     if (lseek(fd, 0, SEEK_SET) == -1)
> > > > > > +             return -errno;
> > > > > > +     data = 0;
> > > > > > +     while (data < len) {
> > > > > > +             hole = lseek(fd, data, SEEK_HOLE);
> > > > > > +             if (hole == len)
> > > > > > +                     break;
> > > > > > +             data = lseek(fd, hole, SEEK_DATA);
> > > > > > +             if (data < 0 || hole > data) {
> > > > > > +                     return -EINVAL;
> > > > > > +             }
> > > > > > +             if (IS_HOLE(hole, data)) {
> > > > > > +                     st = hole >> S_SHIFT;
> > > > > > +                     en = data >> S_SHIFT;
> > > > > > +                     nblocks -= (en - st);
> > > > > > +                     for (i = st; i < en; i++)
> > > > > > +                             blks[i] = HOLE_BLK;
> > > > > > +             }
> > > > > > +     }
> > > > > > +     return nblocks;
> > > > > > +}
> > > > > > +
> > > > > > +int erofs_fill_holedata(int *blks, unsigned int nblocks) {
> > > > > > +     int i, nholes = 0;
> > > > > > +     for (i = 0; i < nblocks; i++) {
> > > > > > +             if (blks[i] == -1)
> > > > > > +                     nholes++;
> > > > > > +             else {
> > > > > > +                     blks[i] = nholes;
> > > > > > +                     if (nholes >= (i + 1))
> > > > > > +                             return -EINVAL;
> > > > > > +             }
> > > > > > +     }
> > > > > > +     return 0;
> > > > > > +}
> > > > > > +
> > > > > >  void erofs_inode_manager_init(void)
> > > > > >  {
> > > > > >       unsigned int i;
> > > > > > @@ -305,6 +360,7 @@ static bool erofs_file_is_compressible(struct
> > > > > erofs_inode *inode)
> > > > > >  int erofs_write_file(struct erofs_inode *inode)
> > > > > >  {
> > > > > >       unsigned int nblocks, i;
> > > > > > +     int *blks;
> > > > > >       int ret, fd;
> > > > > >
> > > > > >       if (!inode->i_size) {
> > > > > > @@ -322,7 +378,13 @@ int erofs_write_file(struct erofs_inode
> > *inode)
> > > > > >       /* fallback to all data uncompressed */
> > > > > >       inode->datalayout = EROFS_INODE_FLAT_INLINE;
> > > > > >       nblocks = inode->i_size / EROFS_BLKSIZ;
> > > > > > -
> > > > > > +     blks = malloc(sizeof(int) * nblocks);
> > > > > > +     nblocks = erofs_detect_holes(inode, blks);
> > > > > > +     if (nblocks < 0)
> > > > > > +             return nblocks;
> > > > > > +     if ((ret = erofs_fill_holedata(blks, nblocks)) != 0) {
> > > > > > +             return ret;
> > > > > > +     }
> > > > > >       ret = __allocate_inode_bh_data(inode, nblocks);
> > > > > >       if (ret)
> > > > > >               return ret;
> > > > > > @@ -332,6 +394,8 @@ int erofs_write_file(struct erofs_inode *inode)
> > > > > >               return -errno;
> > > > > >
> > > > > >       for (i = 0; i < nblocks; ++i) {
> > > > > > +             if (blks[i] == HOLE_BLK)
> > > > > > +                     continue;
> > > > > >               char buf[EROFS_BLKSIZ];
> > > > > >
> > > > > >               ret = read(fd, buf, EROFS_BLKSIZ);
> > > > > > @@ -962,3 +1026,4 @@ struct erofs_inode
> > > > > *erofs_mkfs_build_tree_from_path(struct erofs_inode *parent,
> > > > > >       return erofs_mkfs_build_tree(inode);
> > > > > >  }
> > > > > >
> > > > > > +
> > > > > > --
> > > > > > 2.9.3
> > > > > >
> > > > >
> >