Linux-EROFS Archive on lore.kernel.org
 help / color / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Maksym Planeta <mplaneta@os.inf.tu-dresden.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, Song Liu <song@kernel.org>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	linux-crypto@vger.kernel.org, Gao Xiang <xiang@kernel.org>,
	linux-erofs@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: Remove WQ_CPU_INTENSIVE flag from unbound wq's
Date: Thu, 13 Feb 2020 10:36:45 -0500
Message-ID: <20200213153645.GA11313@redhat.com> (raw)
In-Reply-To: <20200213141823.2174236-1-mplaneta@os.inf.tu-dresden.de>

On Thu, Feb 13 2020 at  9:18am -0500,
Maksym Planeta <mplaneta@os.inf.tu-dresden.de> wrote:

> The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for
> unbound wq. I remove this flag from places where unbound queue is
> allocated. This is supposed to improve code readability.
> 
> 1. https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags
> 
> Signed-off-by: Maksym Planeta <mplaneta@os.inf.tu-dresden.de>

What the Documentation says aside, have you cross referenced with the
code?  And/or have you done benchmarks to verify no changes?

Thanks,
Mike


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 14:18 [PATCH] " Maksym Planeta
2020-02-13 15:36 ` Mike Snitzer [this message]
2020-02-13 16:19   ` Maksym Planeta
2020-02-13 23:42     ` Song Liu
2020-02-14  1:39 ` [PATCH] " Gao Xiang
2020-02-14  3:47 ` Zhou Wang

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213153645.GA11313@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mplaneta@os.inf.tu-dresden.de \
    --cc=song@kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \
		linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git