From: Gao Xiang <hsiangkao@redhat.com>
To: Huang Jianan <huangjianan@oppo.com>
Cc: zhangshiming@oppo.com, linux-erofs@lists.ozlabs.org, guoweichao@oppo.com
Subject: Re: [PATCH v2] erofs: fix wrong address in erofs_get_block
Date: Tue, 8 Dec 2020 18:35:35 +0800 [thread overview]
Message-ID: <20201208103535.GA3139231@xiangao.remote.csb> (raw)
In-Reply-To: <9fb238a9-ad1e-cf7b-7b42-291e5f0e8929@huawei.com>
On Tue, Dec 08, 2020 at 05:48:10PM +0800, Chao Yu wrote:
> On 2020/12/8 17:31, Huang Jianan wrote:
> > iblock indicates the number of i_blkbits-sized blocks rather than
> > sectors, fix it.
> >
> > If the data has a disk mapping, map_bh should be used to read the
> > correct data from the device.
>
> Thanks for the fix, I was misled by sector_t type...
>
> What about avoiding using generic_block_bmap() which uses buffer_head
> structure, it limits mapped size to 32-bits:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=b876f4c94c3d1688edea021d45a528571499e0b9
Also a minor thing is to Cc: LKML <linux-kernel@vger.kernel.org>
in the next version and for all kernel patches, which is needed
for upstreaming.
(quite closing to merging window...)
Thanks,
Gao Xiang
>
> Thanks,
next prev parent reply other threads:[~2020-12-08 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 9:31 [PATCH v2] erofs: fix wrong address in erofs_get_block Huang Jianan
2020-12-08 9:48 ` Chao Yu
2020-12-08 10:35 ` Gao Xiang [this message]
2020-12-08 13:09 ` Huang Jianan
2020-12-08 13:07 ` Huang Jianan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208103535.GA3139231@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).