From: Gao Xiang <hsiangkao@redhat.com>
To: 胡玮文 <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fix battach on full buffer block
Date: Tue, 19 Jan 2021 23:43:35 +0800 [thread overview]
Message-ID: <20210119154335.GB2601261@xiangao.remote.csb> (raw)
In-Reply-To: <20210119060256.GA7664@DESKTOP-N4CECTO.huww98.cn>
Hi Weiwen,
On Tue, Jan 19, 2021 at 02:02:56PM +0800, 胡玮文 wrote:
> Hi Xiang,
>
> After further investgate, this bug will not reveal in any released version of
> mkfs.erofs. Previous patch v5 [1] will map all allocated bb when erofs_mapbh()
> is called on an already mapped bb, which triggers this bug. before that patch,
> under the same condition, __erofs_battach() will only be called on bb which is
> not mapped, thus no need to update `tail_blkaddr'.
Good to know this, thanks! I haven't looked into that (I will test it this
weekend.) IMO, although this is not a regression, yet it seems it's potential
harmful if we didn't notice this... So I think a proper testcase is still
useful to look after this... If you have extra time, could you help on it?
Also, without the detail of this, I think the fix might be folded into
the original patchset (could you resend it?). In addition, I think after
last_mapped_block is introduced, we might not need tail_blkaddr anymore,
not sure. But I'm very cautious about this in case of introducing any
new regression...
Thanks,
Gao Xiang
>
> [1]: https://lore.kernel.org/linux-erofs/20210118123431.22533-1-sehuww@mail.scut.edu.cn/
>
> Hu Weiwen
>
next prev parent reply other threads:[~2021-01-19 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 12:39 [PATCH] erofs-utils: fix battach on full buffer block Hu Weiwen
2021-01-18 13:59 ` Gao Xiang
2021-01-18 15:52 ` 胡玮文
2021-01-18 23:28 ` Gao Xiang
2021-01-19 6:02 ` 胡玮文
2021-01-19 15:43 ` Gao Xiang [this message]
2021-01-20 4:57 ` 胡玮文
2021-01-20 5:12 ` Gao Xiang
2021-01-21 6:07 ` 胡玮文
2021-01-21 7:22 ` 胡玮文
2021-01-21 9:22 ` Gao Xiang
2021-01-21 16:26 ` [PATCH v2] " Hu Weiwen
2021-01-22 2:31 ` Gao Xiang
2021-01-22 12:43 ` Gao Xiang
2021-02-14 15:22 ` Gao Xiang via Linux-erofs
2021-02-14 16:00 ` [PATCH v3] erofs-utils: fix battach on full buffer blocks Gao Xiang via Linux-erofs
2021-02-22 15:34 ` Li GuiFu via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119154335.GB2601261@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).