From: Gao Xiang <hsiangkao@redhat.com>
To: 胡玮文 <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fuse: fix random readlink error
Date: Sat, 23 Jan 2021 23:22:13 +0800 [thread overview]
Message-ID: <20210123152213.GB3167351@xiangao.remote.csb> (raw)
In-Reply-To: <20210123131830.GA16490@DESKTOP-N4CECTO.huww98.cn>
On Sat, Jan 23, 2021 at 09:18:30PM +0800, 胡玮文 wrote:
> On Fri, Jan 22, 2021 at 09:49:01AM +0800, Gao Xiang wrote:
> > Hi Weiwen,
> >
> > On Fri, Jan 22, 2021 at 09:00:44AM +0800, 胡玮文 wrote:
> > > Hi Xiang,
> > >
> > > > 在 2021年1月22日,08:34,Gao Xiang <hsiangkao@redhat.com> 写道:
> > > >
> > > > Hi Weiwen,
> > > >
> > > >> On Fri, Jan 22, 2021 at 12:31:43AM +0800, Hu Weiwen wrote:
> > > >> readlink should fill a **null terminated** string in buffer.
> > > >>
> > > >> Also, read should return number of bytes remaining on EOF.
> > > >>
> > > >> Link: https://lore.kernel.org/linux-erofs/20210121101233.GC6680@DESKTOP-N4CECTO.huww98.cn/
> > > >> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
> > > >
> > > > Thanks for catching this!
> > > >
> > > >> ---
> > > >> fuse/main.c | 14 +++++++++++++-
> > > >> 1 file changed, 13 insertions(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/fuse/main.c b/fuse/main.c
> > > >> index c162912..bc1e496 100644
> > > >> --- a/fuse/main.c
> > > >> +++ b/fuse/main.c
> > > >> @@ -71,6 +71,12 @@ static int erofsfuse_read(const char *path, char *buffer,
> > > >> if (ret)
> > > >> return ret;
> > > >>
> > > >> + if (offset >= vi.i_size)
> > > >> + return 0;
> > > >> +
> > > >> + if (offset + size > vi.i_size)
> > > >> + size = vi.i_size - offset;
> > > >> +
> > > >
> > > > It would be better to call erofs_pread() with the original offset
> > > > and size (also I think there is some missing memset(0) for
> > > > !EROFS_MAP_MAPPED), and fix up the return value to the needed value.
> > >
> > > Yes, that is what I have initially tried. But this way is harder than I thought.
> > > EROFS_MAP_MAPPED flag seems to be designed to handle sparse file, and is reused to
> > > represent EOF. So maybe we need a new flag to represent EOF?
> >
> > Nope, I think we just need to handle return value of read, I mean
> >
> > erofs_ilookup()
> >
> > ret = erofs_pread()
> > if (ret)
> > return ret;
> >
> > if (offset + size > vi.i_size)
> > return vi.i_size - offset;
> >
> > return size;
> >
> > Is that enough? Am I missing something?
>
> This should work, except we should also add this branch
>
> if (offset >= vi.i_size)
> return 0;
yeah, agreed. It'd also be added after erofs_pread().
>
> But how this is better than my original patch? I would say my patch should be
> more efficient.
>
> By saying "what I have initially tried" in my last mail, I mean changing
> erofs_pread() to return the number of bytes read (just like pread system call,
> instead of always 0). I think this is easier to understand for others, but
> seems harder to implement. Do you think this is worthful?
>
There are 2 reasons for me to do it at least:
1) need to memset(0) for these unmapped buffers;
2) introduce a hook to fs to read data regardless of i_size,
just as linux kernel page cache approach.
Don't be confused with ->i_size (this is only a EOF-marker) and
the real inode data, that are two different concepts for me, I'd
like to handle all data processing in erofs_pread() (even for
post-EOF case), but only deal with i_size in erofsfuse_read().
Thanks,
Gao Xiang
next prev parent reply other threads:[~2021-01-23 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 10:12 fuse returns ENOENT to openat() for symlink probabilistically 胡玮文
2021-01-21 11:27 ` Gao Xiang
2021-01-21 16:31 ` [PATCH] erofs-utils: fuse: fix random readlink error Hu Weiwen
2021-01-22 0:34 ` Gao Xiang
2021-01-22 1:00 ` 胡玮文
2021-01-22 1:49 ` Gao Xiang
2021-01-23 13:18 ` 胡玮文
2021-01-23 15:22 ` Gao Xiang [this message]
2021-01-23 15:36 ` Gao Xiang
2021-01-29 18:07 ` [PATCH v2] " Hu Weiwen
2021-02-09 19:38 ` Gao Xiang via Linux-erofs
2021-02-13 14:36 ` [PATCH v3] " 胡玮文
2021-02-28 13:30 ` [PATCH v2] " Li GuiFu via Linux-erofs
2021-02-28 13:53 ` [PATCH v4] " Gao Xiang via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123152213.GB3167351@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).