From: Gao Xiang via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Hu Weiwen <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fix BUILD_BUG_ON
Date: Sun, 31 Jan 2021 18:09:15 +0800 [thread overview]
Message-ID: <20210131100909.GA21719@hsiangkao-HP-ZHAN-66-Pro-G1> (raw)
In-Reply-To: <20210131094732.168784-1-sehuww@mail.scut.edu.cn>
On Sun, Jan 31, 2021 at 05:47:32PM +0800, Hu Weiwen wrote:
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
Reviewed-by: Gao Xiang <hsiangkao@aol.com>
Thanks,
Gao Xiang
> ---
> include/erofs/defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/erofs/defs.h b/include/erofs/defs.h
> index b54cd9d..2e40944 100644
> --- a/include/erofs/defs.h
> +++ b/include/erofs/defs.h
> @@ -87,7 +87,7 @@ typedef int64_t s64;
> #ifndef __OPTIMIZE__
> #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2 * !!(condition)]))
> #else
> -#define BUILD_BUG_ON(condition) assert(condition)
> +#define BUILD_BUG_ON(condition) assert(!(condition))
> #endif
>
> #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-01-31 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 9:47 [PATCH] erofs-utils: fix BUILD_BUG_ON Hu Weiwen
2021-01-31 10:09 ` Gao Xiang via Linux-erofs [this message]
2021-02-06 13:55 ` Li GuiFu via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210131100909.GA21719@hsiangkao-HP-ZHAN-66-Pro-G1 \
--to=linux-erofs@lists.ozlabs.org \
--cc=hsiangkao@aol.com \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).