[PATCH] erofs-utils: fix BUILD_BUG_ON

[PATCH] erofs-utils: fix BUILD_BUG_ON

[Hu Weiwen]

Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
---
 include/erofs/defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/erofs/defs.h b/include/erofs/defs.h
index b54cd9d..2e40944 100644
--- a/include/erofs/defs.h
+++ b/include/erofs/defs.h
@@ -87,7 +87,7 @@ typedef int64_t         s64;
 #ifndef __OPTIMIZE__
 #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2 * !!(condition)]))
 #else
-#define BUILD_BUG_ON(condition) assert(condition)
+#define BUILD_BUG_ON(condition) assert(!(condition))
 #endif
 
 #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
-- 
2.25.1

Re: [PATCH] erofs-utils: fix BUILD_BUG_ON

[Gao Xiang via Linux-erofs]

On Sun, Jan 31, 2021 at 05:47:32PM +0800, Hu Weiwen wrote:
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>

Reviewed-by: Gao Xiang <hsiangkao@aol.com>

Thanks,
Gao Xiang

> ---
>  include/erofs/defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/erofs/defs.h b/include/erofs/defs.h
> index b54cd9d..2e40944 100644
> --- a/include/erofs/defs.h
> +++ b/include/erofs/defs.h
> @@ -87,7 +87,7 @@ typedef int64_t         s64;
>  #ifndef __OPTIMIZE__
>  #define BUILD_BUG_ON(condition) ((void)sizeof(char[1 - 2 * !!(condition)]))
>  #else
> -#define BUILD_BUG_ON(condition) assert(condition)
> +#define BUILD_BUG_ON(condition) assert(!(condition))
>  #endif
>  
>  #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
> -- 
> 2.25.1
> 

Re: [PATCH] erofs-utils: fix BUILD_BUG_ON

[Li GuiFu via Linux-erofs]

On 2021/1/31 17:47, Hu Weiwen wrote:
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
> ---
>  include/erofs/defs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>