linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: Hu Weiwen <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: add command line argument to override uid/gid
Date: Thu, 1 Apr 2021 14:01:32 +0800	[thread overview]
Message-ID: <20210401060132.GA3827683@xiangao.remote.csb> (raw)
In-Reply-To: <20210401052903.18700-1-sehuww@mail.scut.edu.cn>

Hi Weiwen,

On Thu, Apr 01, 2021 at 01:29:03PM +0800, Hu Weiwen wrote:
> Also added '--all-root' option to set uid and gid to root conveniently.
> 
> This function can be useful if we want to pack some data owned by user with
> large uid, but we want to use compact inode.
> 
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>

How about using long options for all options, e.g.
 --all-root,
 --force-uid=,
 --force-gid=, (seems squashfs uses such naming).

since I'd like to leave short options for more common usages.

And you might need to update manpage as well, so I can apply it
ASAP...

(Btw, even compact inodes have 16-bit ranges, we could introduce
 some mapping table to remap sparse uid/gid into a compact form,
 if that is what you want, you could help to implement it as well :) )

Thanks,
Gao Xiang


  reply	other threads:[~2021-04-01  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  5:29 [PATCH] erofs-utils: add command line argument to override uid/gid Hu Weiwen
2021-04-01  6:01 ` Gao Xiang [this message]
2021-04-01 11:36   ` [PATCH v2] erofs-utils: add cmd " Hu Weiwen
2021-04-01 12:01     ` Gao Xiang
2021-04-11 13:50       ` Li GuiFu via Linux-erofs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210401060132.GA3827683@xiangao.remote.csb \
    --to=hsiangkao@redhat.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=sehuww@mail.scut.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).