From: Gao Xiang <hsiangkao@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] erofs: fix uninitialized variable i used in a while-loop
Date: Wed, 7 Apr 2021 07:54:01 +0800 [thread overview]
Message-ID: <20210406235401.GA210667@xiangao.remote.csb> (raw)
In-Reply-To: <20210406162718.429852-1-colin.king@canonical.com>
Hi Colin,
On Tue, Apr 06, 2021 at 05:27:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The while-loop iterates until src is non-null or i is 3, however, the
> loop counter i is not intinitialied to zero, causing incorrect iteration
> counts. Fix this by initializing it to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 1aa5f2e2feed ("erofs: support decompress big pcluster for lz4 backend")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thank you very much for catching this! It looks good to me,
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
(btw, may I fold this into the original patchset? since such big pcluster
patchset is just applied to for-next for further integration testing, and
the commit id is not stable yet..)
Thanks,
Gao Xiang
> ---
> fs/erofs/decompressor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
> index fe46a9c34923..8687ff81406b 100644
> --- a/fs/erofs/decompressor.c
> +++ b/fs/erofs/decompressor.c
> @@ -154,6 +154,7 @@ static void *z_erofs_handle_inplace_io(struct z_erofs_decompress_req *rq,
> }
> kunmap_atomic(inpage);
> might_sleep();
> + i = 0;
> while (1) {
> src = vm_map_ram(rq->in, nrpages_in, -1);
> /* retry two more times (totally 3 times) */
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-04-06 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:27 [PATCH][next] erofs: fix uninitialized variable i used in a while-loop Colin King
2021-04-06 23:54 ` Gao Xiang [this message]
2021-04-07 3:38 ` Joe Perches
2021-04-07 3:51 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406235401.GA210667@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).