From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23A4C433B4 for ; Tue, 27 Apr 2021 02:50:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59BD461289 for ; Tue, 27 Apr 2021 02:50:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59BD461289 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FTmTH0V1Fz2yx9 for ; Tue, 27 Apr 2021 12:50:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FW0guIzJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=xiang@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FW0guIzJ; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FTmTD6sBfz2xZB for ; Tue, 27 Apr 2021 12:50:08 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id AC8BA6023B; Tue, 27 Apr 2021 02:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619491806; bh=jNYn19U4dhZVGahgF+rsxkUDVtUaGkaSyCxD+ycuX/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FW0guIzJv0WZn0/CwuJHe/wIFaIAq+OcE4B8J5iYgsudVq/5yALX0eLAh1UkLkX6e NROKiDwPaix0rWtonSu7X6m/X0bnf03Ey4VEWY+jv4EwtcYQ4WyahJBci0mlwycVjs 5Z5qIoi/fyC5mt80qOKs6tEoex/kWWqJjdGw89PAK5fLY9zsHW9zh5kFWsYSQB3CDm kouuqYGL6XrxbUWff29H+bEws6HIg5MxkqBb+zc4oki5t/47EWUrb1HwXilQaKDfu1 9f8KAJJjGluIOqXXkZoQGFYA06IkG3fWHOk/gb7uR5+a6dD6aBmaU24WdS+EMzz7pj nBmdw3KZ1wrEg== From: Gao Xiang To: linux-erofs@lists.ozlabs.org, Li Guifu Subject: [PATCH v2 2/3] erofs-utils: warn out experimental big pcluster Date: Tue, 27 Apr 2021 10:49:59 +0800 Message-Id: <20210427024959.10885-1-xiang@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210427023722.7996-2-xiang@kernel.org> References: <20210427023722.7996-2-xiang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gao Xiang Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" It's still an experimental feature for now. Also set the default logging level to 2 in order to print warn messages. Signed-off-by: Gao Xiang --- v2: - use erofs_warn() and set default dbglevel to 2. lib/compress.c | 2 ++ lib/config.c | 2 +- man/mkfs.erofs.1 | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/compress.c b/lib/compress.c index 654286d3f33e..b8bb89e7ae9d 100644 --- a/lib/compress.c +++ b/lib/compress.c @@ -619,6 +619,8 @@ int z_erofs_compress_init(struct erofs_buffer_head *sb_bh) mapheader.h_advise |= Z_EROFS_ADVISE_BIG_PCLUSTER_1; if (!cfg.c_legacy_compress) mapheader.h_advise |= Z_EROFS_ADVISE_BIG_PCLUSTER_2; + + erofs_warn("EXPERIMENTAL big pcluster feature in use. Use at your own risk!"); } mapheader.h_algorithmtype = algorithmtype[1] << 4 | algorithmtype[0]; diff --git a/lib/config.c b/lib/config.c index d733cc366794..bc0afa284807 100644 --- a/lib/config.c +++ b/lib/config.c @@ -17,7 +17,7 @@ void erofs_init_configure(void) { memset(&cfg, 0, sizeof(cfg)); - cfg.c_dbg_lvl = 0; + cfg.c_dbg_lvl = 2; cfg.c_version = PACKAGE_VERSION; cfg.c_dry_run = false; cfg.c_compr_level_master = -1; diff --git a/man/mkfs.erofs.1 b/man/mkfs.erofs.1 index 254c3ec4de41..2520b6a08974 100644 --- a/man/mkfs.erofs.1 +++ b/man/mkfs.erofs.1 @@ -25,7 +25,8 @@ Set an algorithm for file compression, which can be set with an optional compression level separated by a comma. .TP .BI "\-d " # -Specify the level of debugging messages. The default is 0. +Specify the level of debugging messages. The default is 2, which shows basic +warning messages. .TP .BI "\-x " # Specify the upper limit of an xattr which is still inlined. The default is 2. -- 2.20.1