From: Gao Xiang <xiang@kernel.org>
To: linux-erofs@lists.ozlabs.org
Cc: Gao Xiang <xiang@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: [PATCH 1/2] erofs: better comment z_erofs_readahead()
Date: Tue, 6 Jul 2021 02:32:52 +0800 [thread overview]
Message-ID: <20210705183253.14833-1-xiang@kernel.org> (raw)
Add some words about the traversal order and its pagepool usage.
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Gao Xiang <xiang@kernel.org>
---
fs/erofs/zdata.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index cb4d0889eca9..054b9839e9db 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -1424,6 +1424,16 @@ static void z_erofs_readahead(struct readahead_control *rac)
f.readahead = true;
f.headoffset = readahead_pos(rac);
+ /*
+ * All pages are locked in the forward order in advance, so directly
+ * traverse pages in the reverse order since:
+ * 1) more effective to get each extent start offset, calculate partial
+ * decompressed length w/o knowing the full extent length (which is
+ * more metadata costly). If traversing in the normal order, it's
+ * mandatory to get full extent length one-by-one.
+ * 2) submission chain can be then in the forward order since
+ * pclusters are all inserted at head.
+ */
while ((page = readahead_page(rac))) {
prefetchw(&page->flags);
@@ -1460,7 +1470,7 @@ static void z_erofs_readahead(struct readahead_control *rac)
if (f.map.mpage)
put_page(f.map.mpage);
- /* clean up the remaining free pages */
+ /* drain the on-stack pagepool with unused non-LRU temporary pages */
put_pages_list(&pagepool);
}
--
2.20.1
next reply other threads:[~2021-07-05 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 18:32 Gao Xiang [this message]
2021-07-05 18:32 ` [RFC PATCH 2/2] erofs: directly traverse pages in z_erofs_readahead() Gao Xiang
2021-07-05 20:15 ` Matthew Wilcox
2021-07-05 22:48 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705183253.14833-1-xiang@kernel.org \
--to=xiang@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).