From: Wei Yongjun <weiyongjun1@huawei.com>
To: <weiyongjun1@huawei.com>, Huang Jianan <huangjianan@oppo.com>,
Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>
Cc: kernel-janitors@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static
Date: Sun, 8 Aug 2021 06:33:43 +0000 [thread overview]
Message-ID: <20210808063343.255817-1-weiyongjun1@huawei.com> (raw)
The sparse tool complains as follows:
fs/erofs/data.c:150:24: warning:
symbol 'erofs_iomap_ops' was not declared. Should it be static?
This symbol is not used outside of data.c, so marks it static.
Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
fs/erofs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 4ea10b31790c..b2a22aabc9bc 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -147,7 +147,7 @@ static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
return written;
}
-const struct iomap_ops erofs_iomap_ops = {
+static const struct iomap_ops erofs_iomap_ops = {
.iomap_begin = erofs_iomap_begin,
.iomap_end = erofs_iomap_end,
};
next reply other threads:[~2021-08-08 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 6:33 Wei Yongjun [this message]
2021-08-08 13:19 ` [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static Gao Xiang
2021-08-08 23:56 ` Chao Yu
2021-08-09 2:49 ` weiyongjun (A)
2021-08-09 3:06 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808063343.255817-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=chao@kernel.org \
--cc=huangjianan@oppo.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).