linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Huang Jianan <jnhuang95@gmail.com>
To: linux-erofs@lists.ozlabs.org
Subject: [PATCH V2 4/6] erofs-utils: remove unnecessary codes
Date: Fri,  3 Sep 2021 21:40:33 +0800	[thread overview]
Message-ID: <20210903134035.12507-5-jnhuang95@gmail.com> (raw)
In-Reply-To: <20210903134035.12507-1-jnhuang95@gmail.com>

From: Huang Jianan <huangjianan@oppo.com>

Signed-off-by: Huang Jianan <huangjianan@oppo.com>
---
 fuse/main.c | 5 +----
 lib/inode.c | 4 ----
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/fuse/main.c b/fuse/main.c
index fca4d7f..8137421 100644
--- a/fuse/main.c
+++ b/fuse/main.c
@@ -109,16 +109,13 @@ static struct options {
 	bool odebug;
 } fusecfg;
 
-#define OPTION(t, p)                           \
-    { t, offsetof(struct options, p), 1 }
+#define OPTION(t, p) { t, offsetof(struct options, p), 1 }
 static const struct fuse_opt option_spec[] = {
 	OPTION("--dbglevel=%u", debug_lvl),
 	OPTION("--help", show_help),
 	FUSE_OPT_END
 };
 
-#define OPTION(t, p)    { t, offsetof(struct options, p), 1 }
-
 static void usage(void)
 {
 	struct fuse_args args = FUSE_ARGS_INIT(0, NULL);
diff --git a/lib/inode.c b/lib/inode.c
index 97ee2c9..61dc802 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -677,11 +677,7 @@ out:
 		 * Don't leave DATA buffers which were written in the global
 		 * buffer list. It will make balloc() slowly.
 		 */
-#if 0
-		bh->op = &erofs_drop_directly_bhops;
-#else
 		erofs_bdrop(bh, false);
-#endif
 		inode->bh_data = NULL;
 	}
 	return 0;
-- 
2.25.1


  parent reply	other threads:[~2021-09-03 13:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 16:51 [PATCH 0/5] erofs-utils: fix checkpatch.pl complains Huang Jianan
2021-08-31 16:51 ` [PATCH 1/5] erofs-utils: remove filename in the file Huang Jianan
2021-09-03  3:09   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 2/5] erofs-utils: fix SPDX comment style Huang Jianan
2021-09-03  3:10   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 3/5] erofs-utils: fix general style problem Huang Jianan
2021-09-03  3:12   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 4/5] erofs-utils: remove unnecessary codes and comments Huang Jianan
2021-09-03  3:17   ` Gao Xiang
2021-08-31 16:51 ` [PATCH 5/5] erofs-utils: fix print style Huang Jianan
2021-09-03  3:18   ` Gao Xiang
2021-09-03 13:40 ` [PATCH V2 0/6] erofs-utils: fix checkpatch.pl complains Huang Jianan
2021-09-03 13:40   ` [PATCH V2 1/6] erofs-utils: clean up file headers & footers Huang Jianan
2021-09-03 15:03     ` Gao Xiang
2021-09-03 13:40   ` [PATCH V2 2/6] erofs-utils: fix SPDX comment style Huang Jianan
2021-09-03 13:40   ` [PATCH V2 3/6] erofs-utils: fix general style problem Huang Jianan
2021-09-03 13:40   ` Huang Jianan [this message]
2021-09-03 15:10     ` [PATCH V2 4/6] erofs-utils: remove unnecessary codes Gao Xiang
2021-09-03 13:40   ` [PATCH V2 5/6] erofs-utils: fix print style Huang Jianan
2021-09-03 13:40   ` [PATCH V2 6/6] erofs-utils: add missing /* fallthrough */ Huang Jianan
2021-09-03 15:21     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903134035.12507-5-jnhuang95@gmail.com \
    --to=jnhuang95@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).