linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Huang Jianan <huangjianan@oppo.com>
Cc: yh@oppo.com, kevin.liw@oppo.com, guoweichao@oppo.com,
	linux-erofs@lists.ozlabs.org, guanyuwei@oppo.com
Subject: Re: [PATCH v3] erofs-utils: support per-inode compress pcluster
Date: Tue, 7 Sep 2021 08:12:55 +0800	[thread overview]
Message-ID: <20210907001250.GD23541@hsiangkao-HP-ZHAN-66-Pro-G1> (raw)
In-Reply-To: <c234da57-dc77-e1c9-d17e-41e4e873834e@oppo.com>

On Mon, Sep 06, 2021 at 05:38:43PM +0800, Huang Jianan via Linux-erofs wrote:
> 在 2021/9/6 1:59, Gao Xiang 写道:
> > On Wed, Aug 25, 2021 at 11:35:23AM +0800, Huang Jianan via Linux-erofs wrote:
> > > Add an option to configure per-inode compression strategy. Each line
> > > of the file should be in the following form:
> > > 
> > > <Regular-expression> <pcluster-in-bytes>
> > > 
> > > When pcluster is 0, it means that the file shouldn't be compressed.
> > > 
> > > Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> > > ---
> > > changes since v2:
> > >   - change compress_rule to compress_hints for better understanding. (Gao Xiang)
> > >   - use default "-C" value when input physical clustersize is invalid. (Gao Xiang)
> > >   - change the val of WITH_ANDROID option to a separated patch. (Gao Xiang)
> > > 
> > > changes since v1:
> > >   - rename c_pclusterblks to c_physical_clusterblks and place it in union.
> > >   - change cfg.c_physical_clusterblks > 1 to erofs_sb_has_big_pcluster() since
> > >     it's per-inode compression strategy.
> > > 
> > Hi Jianan,
> > 
> > I sorted out a version this weekend (e.g. bump up max pclustersize if
> > needed and update the man page), would you mind confirm on your side
> > as well?
> Hi Xiang,
> 
> Thanks for your modification, looks good to me.
> > Also, it'd be better to add some functionality testcases to cover this
> > if you have extra time:
> Ok, should I use the experimental-tests branch now?

Yeah, please check out this if you have extra time.

Thanks,
Gao Xiang
 
> 
> Thanks,
> Jianan
> > Thanks,
> > Gao Xiang

  reply	other threads:[~2021-09-07  0:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  9:40 [PATCH] " Huang Jianan via Linux-erofs
2021-08-18  4:27 ` [PATCH v2] " Huang Jianan via Linux-erofs
2021-08-25  1:17   ` Gao Xiang
2021-08-25  1:27     ` Gao Xiang
2021-08-25  2:38       ` Huang Jianan via Linux-erofs
2021-08-25  3:35   ` [PATCH v3] " Huang Jianan via Linux-erofs
2021-09-05 17:59     ` Gao Xiang
2021-09-06  9:38       ` Huang Jianan via Linux-erofs
2021-09-07  0:12         ` Gao Xiang [this message]
2021-09-15 11:21           ` [PATCH] erofs-utils: tests: check the compress-hints functionality Huang Jianan via Linux-erofs
2021-09-15 15:10             ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907001250.GD23541@hsiangkao-HP-ZHAN-66-Pro-G1 \
    --to=xiang@kernel.org \
    --cc=guanyuwei@oppo.com \
    --cc=guoweichao@oppo.com \
    --cc=huangjianan@oppo.com \
    --cc=kevin.liw@oppo.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=yh@oppo.com \
    --subject='Re: [PATCH v3] erofs-utils: support per-inode compress pcluster' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).