Re: [PATCH v3] erofs-utils: support per-inode compress pcluster

[Gao Xiang <xiang@kernel.org>]

On Mon, Sep 06, 2021 at 05:38:43PM +0800, Huang Jianan via Linux-erofs wrote:
> 在 2021/9/6 1:59, Gao Xiang 写道:
> > On Wed, Aug 25, 2021 at 11:35:23AM +0800, Huang Jianan via Linux-erofs wrote:
> > > Add an option to configure per-inode compression strategy. Each line
> > > of the file should be in the following form:
> > > 
> > > <Regular-expression> <pcluster-in-bytes>
> > > 
> > > When pcluster is 0, it means that the file shouldn't be compressed.
> > > 
> > > Signed-off-by: Huang Jianan <huangjianan@oppo.com>
> > > ---
> > > changes since v2:
> > >   - change compress_rule to compress_hints for better understanding. (Gao Xiang)
> > >   - use default "-C" value when input physical clustersize is invalid. (Gao Xiang)
> > >   - change the val of WITH_ANDROID option to a separated patch. (Gao Xiang)
> > > 
> > > changes since v1:
> > >   - rename c_pclusterblks to c_physical_clusterblks and place it in union.
> > >   - change cfg.c_physical_clusterblks > 1 to erofs_sb_has_big_pcluster() since
> > >     it's per-inode compression strategy.
> > > 
> > Hi Jianan,
> > 
> > I sorted out a version this weekend (e.g. bump up max pclustersize if
> > needed and update the man page), would you mind confirm on your side
> > as well?
> Hi Xiang,
> 
> Thanks for your modification, looks good to me.
> > Also, it'd be better to add some functionality testcases to cover this
> > if you have extra time:
> Ok, should I use the experimental-tests branch now?

Yeah, please check out this if you have extra time.

Thanks,
Gao Xiang
 
> 
> Thanks,
> Jianan
> > Thanks,
> > Gao Xiang