linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Yue Hu <zbestahu@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, zbestahu@163.com,
	huyue2@yulong.com, linux-erofs@lists.ozlabs.org,
	zhangwen@yulong.com
Subject: Re: [PATCH] erofs: fix compacted_2b if compacted_4b_initial > totalidx
Date: Tue, 14 Sep 2021 12:57:48 +0800	[thread overview]
Message-ID: <20210914125748.00003cd2.zbestahu@gmail.com> (raw)
In-Reply-To: <YUAm+kOdKcCzgcEy@B-P7TQMD6M-0146.local>

On Tue, 14 Sep 2021 12:37:14 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:

> On Tue, Sep 14, 2021 at 11:59:15AM +0800, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> > 
> > Currently, the whole indexes will only be compacted 4B if
> > compacted_4b_initial > totalidx. So, the calculated compacted_2b
> > is worthless for that case. It may waste CPU resources.
> > 
> > No need to update compacted_4b_initial as mkfs since it's used to
> > fulfill the alignment of the 1st compacted_2b pack and would handle
> > the case above.
> > 
> > We also need to clarify compacted_4b_end here. It's used for the
> > last lclusters which aren't fitted in the previous compacted_2b
> > packs.
> > 
> > Some messages are from Xiang.
> > 
> > Signed-off-by: Yue Hu <huyue2@yulong.com>  
> 
> Looks good to me,
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> (although I think the subject title would be better changed into
>  "clear compacted_2b if compacted_4b_initial > totalidx"

Yeah, 'clear' is much better for this change.

Thanks.

>  since 'fix'-likewise words could trigger some AI bot for stable
>  kernel backporting..)
> 
> Thanks,
> Gao Xiang
> 
> > ---
> >  fs/erofs/zmap.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c
> > index 9fb98d8..aeed404 100644
> > --- a/fs/erofs/zmap.c
> > +++ b/fs/erofs/zmap.c
> > @@ -369,7 +369,8 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m,
> >  	if (compacted_4b_initial == 32 / 4)
> >  		compacted_4b_initial = 0;
> >  
> > -	if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B)
> > +	if ((vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) &&
> > +	    compacted_4b_initial <= totalidx) {
> >  		compacted_2b = rounddown(totalidx - compacted_4b_initial, 16);
> >  	else
> >  		compacted_2b = 0;
> > -- 
> > 1.9.1  


  reply	other threads:[~2021-09-14  4:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  3:59 Yue Hu
2021-09-14  4:37 ` Gao Xiang
2021-09-14  4:57   ` Yue Hu [this message]
2021-09-14  5:11     ` Gao Xiang
2021-09-23 11:49     ` Gao Xiang
2021-09-23 12:50       ` Yue Hu
2021-09-23 15:13       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914125748.00003cd2.zbestahu@gmail.com \
    --to=zbestahu@gmail.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huyue2@yulong.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbestahu@163.com \
    --cc=zhangwen@yulong.com \
    --subject='Re: [PATCH] erofs: fix compacted_2b if compacted_4b_initial > totalidx' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).