From: Weizhao Ouyang <o451686892@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: Weizhao Ouyang <o451686892@gmail.com>
Subject: [PATCH v2] erofs-utils: xattr: skip xattrs with unidentified "system." prefix
Date: Thu, 20 Apr 2023 17:27:39 +0800 [thread overview]
Message-ID: <20230420092739.75464-1-o451686892@gmail.com> (raw)
Skip xattrs with unidentified "system." prefix to avoid ENODATA error.
Such as building AOSP on NFSv4 servers.
Signed-off-by: Weizhao Ouyang <o451686892@gmail.com>
---
include/erofs/xattr.h | 6 ++++++
lib/xattr.c | 12 ++++++++++++
2 files changed, 18 insertions(+)
diff --git a/include/erofs/xattr.h b/include/erofs/xattr.h
index 9efadc5e5e80..de078a5eb08a 100644
--- a/include/erofs/xattr.h
+++ b/include/erofs/xattr.h
@@ -41,6 +41,12 @@ static inline unsigned int xattrblock_offset(unsigned int xattr_id)
(_size - sizeof(struct erofs_xattr_ibody_header)) / \
sizeof(struct erofs_xattr_entry) + 1; })
+#ifndef XATTR_SYSTEM_PREFIX
+#define XATTR_SYSTEM_PREFIX "system."
+#endif
+#ifndef XATTR_SYSTEM_PREFIX_LEN
+#define XATTR_SYSTEM_PREFIX_LEN (sizeof(XATTR_SYSTEM_PREFIX) - 1)
+#endif
#ifndef XATTR_USER_PREFIX
#define XATTR_USER_PREFIX "user."
#endif
diff --git a/lib/xattr.c b/lib/xattr.c
index 6034e7b6b4eb..7c776330bdaa 100644
--- a/lib/xattr.c
+++ b/lib/xattr.c
@@ -288,6 +288,18 @@ static bool erofs_is_skipped_xattr(const char *key)
if (cfg.sehnd && !strcmp(key, XATTR_SECURITY_PREFIX "selinux"))
return true;
#endif
+
+ /* skip xattrs with unidentified "system." prefix */
+ if (!strncmp(key, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN)) {
+ if (!strcmp(key, XATTR_NAME_POSIX_ACL_ACCESS) ||
+ !strcmp(key, XATTR_NAME_POSIX_ACL_DEFAULT)) {
+ return false;
+ } else {
+ erofs_warn("skip unidentified xattr: %s", key);
+ return true;
+ }
+ }
+
return false;
}
--
2.25.1
next reply other threads:[~2023-04-20 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:27 Weizhao Ouyang [this message]
2023-04-20 9:36 ` [PATCH v2] erofs-utils: xattr: skip xattrs with unidentified "system." prefix Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420092739.75464-1-o451686892@gmail.com \
--to=o451686892@gmail.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).