From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0652FC3A5A1 for ; Wed, 28 Aug 2019 14:50:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9612077B for ; Wed, 28 Aug 2019 14:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.ozlabs.org header.i=@lists.ozlabs.org header.b="LkK53ie3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=android.com header.i=@android.com header.b="OlcPfkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9612077B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46JTDT74tczDrBr for ; Thu, 29 Aug 2019 00:50:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.ozlabs.org; s=201707; t=1567003802; bh=Q3F2pMcDVoGjA4gufrXtnB+Ts7KREZEw96QVHlPW7zI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LkK53ie3xKak8mT8mgKK42rHcVPGdYxdjCvNp4uj5N6m464kcgryXDEEdgHiqP3aI xjgVUBF5CbdwHZzCumdwnx8uvraMdK//EPInarJ/ZRYWM23P/QrtNyiAFV7/ZP7xSq I8tqMtdfCVGyYYCMvKHwUZ9mx3/VfPgmaqe2jka7OAKawQg0icGV2lCTgLcu9DIvuS RmVthhzf376paSLI5fwJs+oDSu1fxG5QxySpAfNGARa9/V854K+e0NAky7f5i2q1Tk rfq4IHv5E9WuSHKJXVkV9vq60VIijX/JhqDvyq99gJP5EoTWMBQUURyUejcnTsR2qr M5MsVNtd0iaAQ== Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=android.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=salyzyn@android.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=android.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=android.com header.i=@android.com header.b="OlcPfkFh"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46JT1L3gbZzDqK9 for ; Thu, 29 Aug 2019 00:40:21 +1000 (AEST) Received: by mail-pg1-x542.google.com with SMTP id m3so1566522pgv.13 for ; Wed, 28 Aug 2019 07:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=OlcPfkFh4eVXaPXXhh3cHvgBURsJe3iAt4+TEVeWmIUa8zc09e0oQ5MaZNlepG2vze B3r7RgJuWq9O6TIbswaNUIKe8aYWW+KNRgEXeCMfCvmELHUyftJPl7HAVt/DUWoqH+mt 7FiMUsP13ILyRxskXvgoEKTt4mcyDqpG+bZTW39pIt/5h+k8/JBgcB7qNM0XACYD7ale oWFmT2jC5R2Rv9fP9CO4NSXlbVjGTO4SWvbIfLdPsT4850CBsX7b6iyMaVYsWWgBm0EJ ydfkWGX0BboAbCSeR2RRikvC2V1c34KnlnNThn4oWcDh6RwGfO3sPku0/xiss22u0zC8 qA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=LOFlbIYcxPV0htjFmAU5YA08Q3mBIty9wZMufCF9SQGf1Oe1HPiOYeoddeT9HELEdv BgMga4f8u/QOl8f26ThIgc2ZVJdERpbbSdxBpu+oaaZSo8bmPSpqOwlcHhfiUsnb1SB/ ZbyKF/dY9oqkFYqAOXggMlCyDGkatw0eHfLR3zrKKH4Xq6QK/uoYlyMwVwxj1htVk7lV bE0GIp0HOX7VCUPz7/XziQmO4ORc7wffZJq4po4ZqqJfunau+wMeg0XtXbvu+jhwyfH7 YKIh11u44ALsFhgR8RH/tnVDYvkrrzPj/2gaoEbm3/9lMQ4kqNUuEuD31TMWp5m3/a5a pGcQ== X-Gm-Message-State: APjAAAUziZXTzkNI49gzSq59k2Jp+ZHpRuQR4YxvBR0yMYSdLeY7D3B1 KT5IbyxiAmQY99L5JDOqUw6ykg== X-Google-Smtp-Source: APXvYqxMi0WkPdC/TIWQ/rEP0W+6WEwgY/rp8ZhYjwRr9PMekyUrfkMqryPcx5ziGSRNx/jQnRs5oA== X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr4474530pjb.139.1567003218534; Wed, 28 Aug 2019 07:40:18 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id t9sm7295641pgj.89.2019.08.28.07.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2019 07:40:17 -0700 (PDT) Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr To: Christoph Hellwig References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> Date: Wed, 28 Aug 2019 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mark Salyzyn via Linux-erofs Reply-To: Mark Salyzyn Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, Tejun Heo , Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, "David S. Miller" , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Jan Kara , Eric Biggers , Dominique Martinet , Adrian Hunter , David Howells , Joseph Qi , Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , cluster-devel@redhat.com, Steve French , v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, linux-unionfs@vger.kernel.org, stable@vger.kernel.org, Tyler Hicks , linux-security-module@vger.kernel.org, Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 8/28/19 7:24 AM, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: >> Replace arguments for get and set xattr methods, and __vfs_getxattr >> and __vfs_setaxtr functions with a reference to the following now >> common argument structure: > Yikes. That looks like a mess. Why can't we pass a kernel-only > flag in the existing flags field for ₋>set and add a flags field > to ->get? Passing methods by structure always tends to be a mess. This was a response to GregKH@ criticism, an earlier patch set just added a flag as you stated to get method, until complaints of an excessively long argument list and fragility to add or change more arguments. So many ways have been tried to skin this cat ... the risk was taken to please some, and we now have hundreds of stakeholders, when the first patch set was less than a dozen. A recipe for failure? -- Mark