Linux-EROFS Archive on
 help / color / Atom feed
From: Li GuiFu via Linux-erofs <>
To: Gao Xiang <>,, Li Guifu <>
Subject: Re: [PATCH] erofs-utils: avoid PAGE_SIZE redefinition
Date: Fri, 27 Mar 2020 00:19:46 +0800
Message-ID: <> (raw)
In-Reply-To: <>

On 2020/3/25 16:29, Gao Xiang wrote:
> Buildroot autobuild reported a PAGE_SIZE redefinition with some
> configrations on i586 toolchain [1] (I didn't notice such report
> from erofs-utils travis CI or distribution builds before.)
> In file included from config.c:11:
> ../include/erofs/internal.h:27: error: "PAGE_SIZE" redefined [-Werror]
>  #define PAGE_SIZE  (1U << PAGE_SHIFT)
> In file included from ../include/erofs/defs.h:17,
>                  from ../include/erofs/config.h:12,
>                  from ../include/erofs/print.h:12,
>                  from config.c:10:
> .../sysroot/usr/include/limits.h:89: note: this is the location of the previous definition
> cc1: all warnings being treated as errors
> Fix it now.
> [1]
> Signed-off-by: Gao Xiang <>

It looks good
Reviewed-by: Li Guifu <>

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2020-03-25  8:29 ` Gao Xiang via Linux-erofs
2020-03-26 16:19   ` Li GuiFu via Linux-erofs [this message]
2020-03-27  7:42   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on

Archives are clonable:
	git clone --mirror linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ \
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone