From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@aol.com>, linux-erofs@lists.ozlabs.org
Cc: Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH] erofs-utils: mkfs: fix uuid.h location
Date: Sat, 12 Dec 2020 17:04:10 +0800 [thread overview]
Message-ID: <8b27d4e3-46fa-ec9d-409f-6440d5d1749a@aliyun.com> (raw)
In-Reply-To: <20201209004937.1672-1-hsiangkao@aol.com>
On 2020/12/9 8:49, Gao Xiang via Linux-erofs wrote:
> From: Gao Xiang <hsiangkao@aol.com>
>
> As Karel reported [1], "The subdirectory in
> #include <uuid/uuid.h>
>
> is unnecessary (or wrong), if you use
> PKG_CHECK_MODULES([libuuid], [uuid])
>
> than it returns the subdirectory as -I, see
>
> $ pkg-config --cflags uuid
> -I/usr/include/uuid
>
> so the correct way is
> #include <uuid.h>". Let's fix it now!
>
> [1] https://lore.kernel.org/r/20201208100910.dqqh5cqihewkyetc@ws.net.home
>
> Reported-by: Karel Zak <kzak@redhat.com>
> Fixes: e023d47593ff ("erofs-utils: support 128-bit filesystem UUID")
> Signed-off-by: Gao Xiang <hsiangkao@aol.com>
> ---
> mkfs/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
Thanks,
prev parent reply other threads:[~2020-12-12 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201209004937.1672-1-hsiangkao.ref@aol.com>
2020-12-09 0:49 ` [PATCH] erofs-utils: mkfs: fix uuid.h location Gao Xiang via Linux-erofs
2020-12-12 9:04 ` Li GuiFu via Linux-erofs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b27d4e3-46fa-ec9d-409f-6440d5d1749a@aliyun.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=bluce.lee@aliyun.com \
--cc=hsiangkao@aol.com \
--cc=kzak@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).