From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <gaoxiang25@huawei.com>, <linux-erofs@lists.ozlabs.org>
Cc: Lasse Collin <lasse.collin@tukaani.org>,
Miao Xie <miaoxie@huawei.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] erofs: use LZ4_decompress_safe() for full decoding
Date: Tue, 3 Mar 2020 17:49:54 +0800 [thread overview]
Message-ID: <8c1a119e-7f3d-a42d-3208-d30b476baf73@huawei.com> (raw)
In-Reply-To: <20200226023011.103798-2-gaoxiang25@huawei.com>
On 2020/2/26 10:30, Gao Xiang wrote:
> As Lasse pointed out, "EROFS uses LZ4_decompress_safe_partial
> for both partial and full blocks. Thus when it is decoding a
> full block, it doesn't know if the LZ4 decoder actually decoded
> all the input. The real uncompressed size could be bigger than
> the value stored in the file system metadata.
>
> Using LZ4_decompress_safe instead of _safe_partial when
> decompressing a full block would help to detect errors."
>
> So it's reasonable to use _safe in case of corrupted images and
> it might have some speed gain as well although I didn't observe
> much difference.
>
> Cc: Lasse Collin <lasse.collin@tukaani.org>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
next prev parent reply other threads:[~2020-03-03 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 2:30 [PATCH 1/3] erofs: correct the remaining shrink objects Gao Xiang
2020-02-26 2:30 ` [PATCH 2/3] erofs: use LZ4_decompress_safe() for full decoding Gao Xiang
2020-03-03 9:49 ` Chao Yu [this message]
2020-02-26 2:30 ` [PATCH 3/3] erofs: handle corrupted images whose decompressed size less than it'd be Gao Xiang
2020-02-26 2:34 ` Eric Biggers
2020-02-26 2:40 ` Gao Xiang
2020-02-26 2:44 ` Gao Xiang
2020-03-03 9:51 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c1a119e-7f3d-a42d-3208-d30b476baf73@huawei.com \
--to=yuchao0@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=lasse.collin@tukaani.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).