linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <xiang@kernel.org>, Hu Weiwen <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2] erofs-utils: add cmd argument to override uid/gid
Date: Sun, 11 Apr 2021 21:50:33 +0800	[thread overview]
Message-ID: <8ee275dd-79b4-9e23-a1cb-c68ca0bc1f5b@aliyun.com> (raw)
In-Reply-To: <20210401120102.GA30040@hsiangkao-HP-ZHAN-66-Pro-G1>



On 2021/4/1 20:01, Gao Xiang wrote:
> On Thu, Apr 01, 2021 at 07:36:10PM +0800, Hu Weiwen wrote:
>> Also added '--all-root' option to set uid and gid to root conveniently.
>>
>> This function can be useful if we want to pack some data owned by user with
>> large uid, but we want to use compact inode.
>>
>> This interface mimics that of 'mksquashfs'.
>>
>> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
> 
> Yey! I've applied with the following modification,
> 
> diff --git a/include/erofs/config.h b/include/erofs/config.h
> index e6eaef66b91c..15390f4ca9c8 100644
> --- a/include/erofs/config.h
> +++ b/include/erofs/config.h
> @@ -54,8 +54,7 @@ struct erofs_configure {
>  	/* < 0, xattr disabled and INT_MAX, always use inline xattrs */
>  	int c_inline_xattr_tolerance;
>  	u64 c_unix_timestamp;
> -	u32 c_uid;
> -	u32 c_gid;
> +	u32 c_uid, c_gid;
>  #ifdef WITH_ANDROID
>  	char *mount_point;
>  	char *target_out_path;
> diff --git a/mkfs/main.c b/mkfs/main.c
> index 72b7f17e1c66..d8823b539194 100644
> --- a/mkfs/main.c
> +++ b/mkfs/main.c
> @@ -77,8 +77,8 @@ static void usage(void)
>  #ifdef HAVE_LIBSELINUX
>  	      " --file-contexts=X  specify a file contexts file to setup selinux labels\n"
>  #endif
> -	      " --force-uid=UID    set all file uids to UID\n"
> -	      " --force-gid=GID    set all file gids to GID\n"
> +	      " --force-uid=#      set all file uids to # (# = UID)\n"
> +	      " --force-gid=#      set all file gids to # (# = GID)\n"
>  	      " --all-root         make all files owned by root\n"
>  	      " --help             display this help and exit\n"
>  #ifdef WITH_ANDROID
> 
> Otherwise looks good to me,
> Reviewed-by: Gao Xiang <xiang@kernel.org>
> 

It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>

Thanks,

      reply	other threads:[~2021-04-11 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  5:29 [PATCH] erofs-utils: add command line argument to override uid/gid Hu Weiwen
2021-04-01  6:01 ` Gao Xiang
2021-04-01 11:36   ` [PATCH v2] erofs-utils: add cmd " Hu Weiwen
2021-04-01 12:01     ` Gao Xiang
2021-04-11 13:50       ` Li GuiFu via Linux-erofs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ee275dd-79b4-9e23-a1cb-c68ca0bc1f5b@aliyun.com \
    --to=linux-erofs@lists.ozlabs.org \
    --cc=bluce.lee@aliyun.com \
    --cc=sehuww@mail.scut.edu.cn \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).