From: JeffleXu <jefflexu@linux.alibaba.com>
To: Jia Zhu <zhujia.zj@bytedance.com>, linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yinxin.x@bytedance.com
Subject: Re: [PATCH V4 3/6] erofs: introduce fscache-based domain
Date: Fri, 16 Sep 2022 10:35:54 +0800 [thread overview]
Message-ID: <96a96aff-5d16-a2e3-2529-58e154e0f728@linux.alibaba.com> (raw)
In-Reply-To: <20220915124213.25767-4-zhujia.zj@bytedance.com>
On 9/15/22 8:42 PM, Jia Zhu wrote:
>
> +static void erofs_fscache_domain_put(struct erofs_domain *domain)
> +{
> + if (!domain)
> + return;
> + mutex_lock(&erofs_domain_list_lock);
> + if (refcount_dec_and_test(&domain->ref)) {
> + list_del(&domain->list);
> + fscache_relinquish_volume(domain->volume, NULL, false);
> + mutex_unlock(&erofs_domain_list_lock);
I think we can mutex_unlock as long as the domain is removed from the list.
Otherwise LGTM.
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
next prev parent reply other threads:[~2022-09-16 2:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 12:42 [PATCH V4 0/6] Introduce erofs shared domain Jia Zhu
2022-09-15 12:42 ` [PATCH V4 1/6] erofs: use kill_anon_super() to kill super in fscache mode Jia Zhu
2022-09-16 1:43 ` JeffleXu
2022-09-15 12:42 ` [PATCH V4 2/6] erofs: code clean up for fscache Jia Zhu
2022-09-16 2:02 ` JeffleXu
2022-09-15 12:42 ` [PATCH V4 3/6] erofs: introduce fscache-based domain Jia Zhu
2022-09-16 2:35 ` JeffleXu [this message]
2022-09-16 2:57 ` JeffleXu
2022-09-15 12:42 ` [PATCH V4 4/6] erofs: introduce a pseudo mnt to manage shared cookies Jia Zhu
2022-09-16 3:19 ` JeffleXu
2022-09-15 12:42 ` [PATCH V4 5/6] erofs: Support sharing cookies in the same domain Jia Zhu
2022-09-16 3:45 ` JeffleXu
2022-09-15 12:42 ` [PATCH V4 6/6] erofs: introduce 'domain_id' mount option Jia Zhu
2022-09-16 5:10 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a96aff-5d16-a2e3-2529-58e154e0f728@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yinxin.x@bytedance.com \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).