Linux-EROFS Archive on lore.kernel.org
 help / color / Atom feed
From: Pratik Shinde <pratikshinde320@gmail.com>
To: Gao Xiang <hsiangkao@aol.com>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: Support for uncompressed sparse files.
Date: Mon, 25 Nov 2019 00:00:28 +0530
Message-ID: <CAGu0czTT=s8xU0uLruAE3a3jnPDd_eQS290u45OACYrb3Z3L0Q@mail.gmail.com> (raw)
In-Reply-To: <20191117173027.GA21516@hsiangkao-HP-ZHAN-66-Pro-G1>

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

Hi Gao,

In the current design, for uncompressed files, we only maintain the
starting block address.because rest of the data blocks will follow it
(continuous allocation).
For sparse files we have to do following
1) We don't want to allocate space for holes (Holes will be multiple of
EROFS_BLKSZ ?)
2) For read() operation on holes, return null data  = '\0'.

I have few thoughts about it:
1) Without changing the current design much, we want to keep track of holes
in file.
    e.g maintaining some table OR bitmap(per inode), to check if given
offset falls inside hole or real data.
2) Accordingly changing the readpage() aop.

Let me know you thoughts on this.

--Pratik.

On Sun, Nov 17, 2019 at 11:01 PM Gao Xiang <hsiangkao@aol.com> wrote:

> Hi Pratik,
>
> On Sun, Nov 17, 2019 at 03:40:43PM +0530, Pratik Shinde wrote:
> > Hello Gao,
> >
> > I have started working on above functionality for erofs.
> > First thing we need to do is detect sparse files & determine location of
> > holes in it.
> >
> > I was thinking of using lseek() with SEEK_HOLE & SEEK_DATA for detecting
> > holes.
> > Let me know what you think about the approach OR any other better
> approach
> > in your mind.
> >
> > PS : support for SEEK_HOLE & SEEK_DATA came in 3.4 kernel.
>
> That is a good start to detect sparse files by SEEK_HOLE & SEEK_DATA.
>
> And as the first step, we need to design the on-disk extent format
> for uncompressed sparse files. Is there some preliminary proposed
> ideas for this as well? :-) (I'm not sure whether Chao is busy in
> other stuffs now, we'd get in line with sparse on-disk format.)
>
> Thanks,
> Gao Xiang
>
>

[-- Attachment #2: Type: text/html, Size: 2241 bytes --]

<div dir="ltr"><div>Hi Gao,</div><div><br></div><div>In the current design, for uncompressed files, we only maintain the starting block address.because rest of the data blocks will follow it (continuous allocation).</div><div>For sparse files we have to do following</div><div>1) We don&#39;t want to allocate space for holes (Holes will be multiple of EROFS_BLKSZ ?)</div><div>2) For read() operation on holes, return null data  = &#39;\0&#39;.</div><div><br></div><div>I have few thoughts about it:</div><div>1) Without changing the current design much, we want to keep track of holes in file.</div><div>    e.g maintaining some table OR bitmap(per inode), to check if given offset falls inside hole or real data.</div><div>2) Accordingly changing the readpage() aop.</div><div><br></div><div>Let me know you thoughts on this.</div><div><br></div><div>--Pratik.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 17, 2019 at 11:01 PM Gao Xiang &lt;<a href="mailto:hsiangkao@aol.com">hsiangkao@aol.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Pratik,<br>
<br>
On Sun, Nov 17, 2019 at 03:40:43PM +0530, Pratik Shinde wrote:<br>
&gt; Hello Gao,<br>
&gt; <br>
&gt; I have started working on above functionality for erofs.<br>
&gt; First thing we need to do is detect sparse files &amp; determine location of<br>
&gt; holes in it.<br>
&gt; <br>
&gt; I was thinking of using lseek() with SEEK_HOLE &amp; SEEK_DATA for detecting<br>
&gt; holes.<br>
&gt; Let me know what you think about the approach OR any other better approach<br>
&gt; in your mind.<br>
&gt; <br>
&gt; PS : support for SEEK_HOLE &amp; SEEK_DATA came in 3.4 kernel.<br>
<br>
That is a good start to detect sparse files by SEEK_HOLE &amp; SEEK_DATA.<br>
<br>
And as the first step, we need to design the on-disk extent format<br>
for uncompressed sparse files. Is there some preliminary proposed<br>
ideas for this as well? :-) (I&#39;m not sure whether Chao is busy in<br>
other stuffs now, we&#39;d get in line with sparse on-disk format.)<br>
<br>
Thanks,<br>
Gao Xiang<br>
<br>
</blockquote></div>

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 10:10 Pratik Shinde
2019-11-17 17:30 ` Gao Xiang via Linux-erofs
2019-11-24 18:30   ` Pratik Shinde [this message]
2019-11-24 19:10     ` Gao Xiang via Linux-erofs

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGu0czTT=s8xU0uLruAE3a3jnPDd_eQS290u45OACYrb3Z3L0Q@mail.gmail.com' \
    --to=pratikshinde320@gmail.com \
    --cc=hsiangkao@aol.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \
		linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git