From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Linux NVDIMM <nvdimm@lists.linux.dev>,
Mike Snitzer <snitzer@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-erofs@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-xfs <linux-xfs@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem
Date: Fri, 19 Nov 2021 09:21:09 -0800 [thread overview]
Message-ID: <CAPcyv4iFG0n-vdaEi4h5ken6mPrgW6Kz6UXCTRfaHi-c99GBnw@mail.gmail.com> (raw)
In-Reply-To: <20211119065645.GB15524@lst.de>
On Thu, Nov 18, 2021 at 10:56 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, Nov 17, 2021 at 09:44:25AM -0800, Dan Williams wrote:
> > On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > dax_attribute_group is only used by the pmem driver, and can avoid the
> > > completely pointless lookup by the disk name if moved there. This
> > > leaves just a single caller of dax_get_by_host, so move dax_get_by_host
> > > into the same ifdef block as that caller.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > > Link: https://lore.kernel.org/r/20210922173431.2454024-3-hch@lst.de
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >
> > This one already made v5.16-rc1.
>
> Yes, but 5.16-rc1 did not exist yet when I pointed the series.
>
> Note that the series also has a conflict against 5.16-rc1 in pmem.c,
> and buildbot pointed out the file systems need explicit dax.h
> includes in a few files for some configurations.
>
> The current branch is here, I just did not bother to repost without
> any comments:
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dax-block-cleanup
>
> no functional changes.
Do you just want to send me a pull request after you add all the acks?
next prev parent reply other threads:[~2021-11-19 17:21 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 8:32 decouple DAX from block devices Christoph Hellwig
2021-11-09 8:32 ` [PATCH 01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem Christoph Hellwig
2021-11-17 17:44 ` Dan Williams
2021-11-19 6:56 ` Christoph Hellwig
2021-11-19 17:21 ` Dan Williams [this message]
2021-11-09 8:32 ` [PATCH 02/29] dm: make the DAX support dependend on CONFIG_FS_DAX Christoph Hellwig
2021-11-17 17:23 ` Dan Williams
2021-11-19 6:54 ` Christoph Hellwig
2021-11-23 2:54 ` Dan Williams
2021-11-23 5:56 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 03/29] dax: remove CONFIG_DAX_DRIVER Christoph Hellwig
2021-11-17 17:43 ` Dan Williams
2021-11-23 2:54 ` Dan Williams
2021-11-09 8:32 ` [PATCH 04/29] dax: simplify the dax_device <-> gendisk association Christoph Hellwig
2021-11-23 3:33 ` Dan Williams
2021-11-23 5:57 ` Christoph Hellwig
2021-11-23 19:33 ` Dan Williams
2021-11-09 8:32 ` [PATCH 05/29] dax: remove the pgmap sanity checks in generic_fsdax_supported Christoph Hellwig
2021-11-23 3:35 ` Dan Williams
2021-11-09 8:32 ` [PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev Christoph Hellwig
2021-11-23 3:41 ` Dan Williams
2021-11-23 22:25 ` Darrick J. Wong
2021-11-24 6:36 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 07/29] xfs: factor out a xfs_setup_dax_always helper Christoph Hellwig
2021-11-17 17:31 ` Darrick J. Wong
2021-11-23 3:51 ` Dan Williams
2021-11-09 8:32 ` [PATCH 08/29] dax: remove dax_capable Christoph Hellwig
2021-11-23 3:58 ` Dan Williams
2021-11-23 22:31 ` Darrick J. Wong
2021-11-24 6:37 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 09/29] dm-linear: add a linear_dax_pgoff helper Christoph Hellwig
2021-11-23 3:59 ` Dan Williams
2021-11-09 8:32 ` [PATCH 10/29] dm-log-writes: add a log_writes_dax_pgoff helper Christoph Hellwig
2021-11-23 4:02 ` Dan Williams
2021-11-09 8:32 ` [PATCH 11/29] dm-stripe: add a stripe_dax_pgoff helper Christoph Hellwig
2021-11-23 4:16 ` Dan Williams
2021-11-09 8:32 ` [PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax Christoph Hellwig
2021-11-23 4:17 ` Dan Williams
2021-11-23 22:33 ` Darrick J. Wong
2021-11-09 8:32 ` [PATCH 13/29] fsdax: use a saner calling convention for copy_cow_page_dax Christoph Hellwig
2021-11-23 19:35 ` Dan Williams
2021-11-23 22:33 ` Darrick J. Wong
2021-11-09 8:32 ` [PATCH 14/29] fsdax: simplify the pgoff calculation Christoph Hellwig
2021-11-23 19:44 ` Dan Williams
2021-11-23 22:36 ` Darrick J. Wong
2021-11-24 6:39 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 15/29] xfs: add xfs_zero_range and xfs_truncate_page helpers Christoph Hellwig
2021-11-23 21:15 ` Dan Williams
2021-11-23 22:37 ` Darrick J. Wong
2021-11-09 8:32 ` [PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero Christoph Hellwig
2021-11-23 21:16 ` Dan Williams
2021-11-23 22:40 ` Darrick J. Wong
2021-11-09 8:32 ` [PATCH 17/29] fsdax: factor out a dax_memzero helper Christoph Hellwig
2021-11-23 21:22 ` Dan Williams
2021-11-23 22:44 ` Darrick J. Wong
2021-11-24 6:47 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code Christoph Hellwig
2021-11-23 21:46 ` Dan Williams
2021-11-24 6:50 ` Christoph Hellwig
2021-11-23 22:53 ` Darrick J. Wong
2021-11-24 6:52 ` Christoph Hellwig
2021-11-09 8:32 ` [PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super Christoph Hellwig
2021-11-23 21:48 ` Dan Williams
2021-11-23 22:54 ` Darrick J. Wong
2021-11-09 8:33 ` [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super Christoph Hellwig
2021-11-23 21:49 ` Dan Williams
2021-11-23 22:54 ` Darrick J. Wong
2021-11-24 6:53 ` Christoph Hellwig
2021-11-09 8:33 ` [PATCH 21/29] xfs: move dax device handling into xfs_{alloc, free}_buftarg Christoph Hellwig
2021-11-23 22:55 ` [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg Darrick J. Wong
2021-11-24 2:40 ` [PATCH 21/29] xfs: move dax device handling into xfs_{alloc, free}_buftarg Dan Williams
2021-11-24 3:05 ` [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg Darrick J. Wong
2021-11-24 6:55 ` Christoph Hellwig
2021-11-09 8:33 ` [PATCH 22/29] iomap: add a IOMAP_DAX flag Christoph Hellwig
2021-11-23 23:00 ` Darrick J. Wong
2021-11-24 2:47 ` Dan Williams
2021-11-24 7:10 ` Christoph Hellwig
2021-11-09 8:33 ` [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings Christoph Hellwig
2021-11-23 23:01 ` Darrick J. Wong
2021-11-24 7:14 ` Christoph Hellwig
2021-11-24 2:49 ` Dan Williams
2021-11-09 8:33 ` [PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing Christoph Hellwig
2021-11-23 23:02 ` Darrick J. Wong
2021-11-24 2:52 ` Dan Williams
2021-11-09 8:33 ` [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev Christoph Hellwig
2021-11-24 2:56 ` Dan Williams
2021-11-24 6:59 ` Christoph Hellwig
2021-11-09 8:33 ` [PATCH 26/29] fsdax: shift partition offset handling into the file systems Christoph Hellwig
2021-11-23 23:11 ` Darrick J. Wong
2021-11-24 3:21 ` Dan Williams
2021-11-24 3:44 ` Gao Xiang
2021-11-09 8:33 ` [PATCH 27/29] dax: fix up some of the block device related ifdefs Christoph Hellwig
2021-11-23 23:13 ` Darrick J. Wong
2021-11-24 3:47 ` Dan Williams
2021-11-09 8:33 ` [PATCH 28/29] iomap: build the block based code conditionally Christoph Hellwig
2021-11-23 23:13 ` Darrick J. Wong
2021-11-24 3:51 ` Dan Williams
2021-11-09 8:33 ` [PATCH 29/29] fsdax: don't require CONFIG_BLOCK Christoph Hellwig
2021-11-23 23:13 ` Darrick J. Wong
2021-11-24 3:52 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4iFG0n-vdaEi4h5ken6mPrgW6Kz6UXCTRfaHi-c99GBnw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).