From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=O50f=L4=lists.ozlabs.org=linux-erofs-bounces+linux-erofs=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 46737C07E95
	for <linux-erofs@archiver.kernel.org>; Sun,  4 Jul 2021 16:44:48 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id C6E4B613E7
	for <linux-erofs@archiver.kernel.org>; Sun,  4 Jul 2021 16:44:47 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6E4B613E7
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org
Received: from boromir.ozlabs.org (localhost [IPv6:::1])
	by lists.ozlabs.org (Postfix) with ESMTP id 4GHvmt2Kfhz301K
	for <linux-erofs@archiver.kernel.org>; Mon,  5 Jul 2021 02:44:46 +1000 (AEST)
Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized)
 smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.42;
 helo=out30-42.freemail.mail.aliyun.com;
 envelope-from=hsiangkao@linux.alibaba.com; receiver=<UNKNOWN>)
Received: from out30-42.freemail.mail.aliyun.com
 (out30-42.freemail.mail.aliyun.com [115.124.30.42])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 4GHvmp27NGz2yNg
 for <linux-erofs@lists.ozlabs.org>; Mon,  5 Jul 2021 02:44:40 +1000 (AEST)
X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R121e4; CH=green; DM=||false|;
 DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04394; MF=hsiangkao@linux.alibaba.com;
 NM=1; PH=DS; RN=2; SR=0; TI=SMTPD_---0UeexvZF_1625417063; 
Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com
 fp:SMTPD_---0UeexvZF_1625417063) by smtp.aliyun-inc.com(127.0.0.1);
 Mon, 05 Jul 2021 00:44:24 +0800
Date: Mon, 5 Jul 2021 00:44:22 +0800
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: =?utf-8?B?6IOh546u5paH?= <sehuww@mail.scut.edu.cn>
Subject: Re: [PATCH] erofs: add "noinline_data" extended option
Message-ID: <YOHlZpBbOZSiOFN/@B-P7TQMD6M-0146.local>
References: <20210704133327.32151-1-hsiangkao@linux.alibaba.com>
 <6B64A221-A140-4C6C-A60D-24EA99DABACC@mail.scut.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6B64A221-A140-4C6C-A60D-24EA99DABACC@mail.scut.edu.cn>
X-BeenThere: linux-erofs@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development of Linux EROFS file system <linux-erofs.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linux-erofs>,
 <mailto:linux-erofs-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linux-erofs/>
List-Post: <mailto:linux-erofs@lists.ozlabs.org>
List-Help: <mailto:linux-erofs-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linux-erofs>,
 <mailto:linux-erofs-request@lists.ozlabs.org?subject=subscribe>
Cc: linux-erofs@lists.ozlabs.org
Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org
Sender: "Linux-erofs"
 <linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org>

On Mon, Jul 05, 2021 at 12:18:38AM +0800, 胡玮文 wrote:
> Should the commit message starts with “erofs-utils:” instead of “erofs:”?

Hi Weiwen,
yeah, you are right, let me revise it in the morning...

Thanks,
Gao Xiang

> 
> > 在 2021年7月4日，21:41，Gao Xiang <hsiangkao@linux.alibaba.com> 写道：
> > 
> > In order to add preliminary DAX feature support.
> > 
> > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> > ---
> > include/erofs/config.h | 1 +
> > lib/inode.c            | 5 +++++
> > mkfs/main.c            | 6 ++++++
> > 3 files changed, 12 insertions(+)
> > 
> > diff --git a/include/erofs/config.h b/include/erofs/config.h
> > index 67e7a0fed24c..8124f3b36baf 100644
> > --- a/include/erofs/config.h
> > +++ b/include/erofs/config.h
> > @@ -44,6 +44,7 @@ struct erofs_configure {
> >    bool c_random_pclusterblks;
> > #endif
> >    char c_timeinherit;
> > +    bool c_noinline_data;
> > 
> > #ifdef HAVE_LIBSELINUX
> >    struct selabel_handle *sehnd;
> > diff --git a/lib/inode.c b/lib/inode.c
> > index 97f0cf763baf..38906370f533 100644
> > --- a/lib/inode.c
> > +++ b/lib/inode.c
> > @@ -562,6 +562,11 @@ static int erofs_prepare_inode_buffer(struct erofs_inode *inode)
> >    if (is_inode_layout_compression(inode))
> >        goto noinline;
> > 
> > +    if (cfg.c_noinline_data && S_ISREG(inode->i_mode)) {
> > +        inode->datalayout = EROFS_INODE_FLAT_PLAIN;
> > +        goto noinline;
> > +    }
> > +
> >    /*
> >     * if the file size is block-aligned for uncompressed files,
> >     * should use EROFS_INODE_FLAT_PLAIN data mapping mode.
> > diff --git a/mkfs/main.c b/mkfs/main.c
> > index 28539da5ea5f..10fe14d7a722 100644
> > --- a/mkfs/main.c
> > +++ b/mkfs/main.c
> > @@ -161,6 +161,12 @@ static int parse_extended_opts(const char *opts)
> >                return -EINVAL;
> >            erofs_sb_clear_sb_chksum();
> >        }
> > +
> > +        if (MATCH_EXTENTED_OPT("noinline_data", token, keylen)) {
> > +            if (vallen)
> > +                return -EINVAL;
> > +            cfg.c_noinline_data = true;
> > +        }
> >    }
> >    return 0;
> > }
> > -- 
> > 2.24.4