* [PATCH v2] erofs-utils: no compression case for tail-end block in vle_write_indexes()
@ 2021-07-23 6:27 Yue Hu
2021-07-24 13:57 ` Gao Xiang
0 siblings, 1 reply; 2+ messages in thread
From: Yue Hu @ 2021-07-23 6:27 UTC (permalink / raw)
To: linux-erofs, xiang; +Cc: huyue2, yuchao0, zhangwen, zbestahu
From: Yue Hu <huyue2@yulong.com>
Note that count value will be always greater than EROFS_BLKSIZ when
calling erofs_compress_destsize() in vle_compress_one(). So, the d1
always >= 1 for compressed block in vle_write_indexes(). That is to
say tail-end block can't be compressed.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
v2: add DBG_BUGON(!raw), a TODO comment.
lib/compress.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/compress.c b/lib/compress.c
index af0c720..40723a1 100644
--- a/lib/compress.c
+++ b/lib/compress.c
@@ -73,10 +73,11 @@ static void vle_write_indexes(struct z_erofs_vle_compress_ctx *ctx,
di.di_clusterofs = cpu_to_le16(ctx->clusterofs);
- /* whether the tail-end (un)compressed block or not */
+ /* whether the tail-end uncompressed block or not */
if (!d1) {
- type = raw ? Z_EROFS_VLE_CLUSTER_TYPE_PLAIN :
- Z_EROFS_VLE_CLUSTER_TYPE_HEAD;
+ /* TODO: tail-packing inline compressed data */
+ DBG_BUGON(!raw);
+ type = Z_EROFS_VLE_CLUSTER_TYPE_PLAIN;
advise = cpu_to_le16(type << Z_EROFS_VLE_DI_CLUSTER_TYPE_BIT);
di.di_advise = advise;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] erofs-utils: no compression case for tail-end block in vle_write_indexes()
2021-07-23 6:27 [PATCH v2] erofs-utils: no compression case for tail-end block in vle_write_indexes() Yue Hu
@ 2021-07-24 13:57 ` Gao Xiang
0 siblings, 0 replies; 2+ messages in thread
From: Gao Xiang @ 2021-07-24 13:57 UTC (permalink / raw)
To: Yue Hu; +Cc: yuchao0, zbestahu, huyue2, xiang, linux-erofs, zhangwen
On Fri, Jul 23, 2021 at 02:27:39PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Note that count value will be always greater than EROFS_BLKSIZ when
> calling erofs_compress_destsize() in vle_compress_one(). So, the d1
> always >= 1 for compressed block in vle_write_indexes(). That is to
> say tail-end block can't be compressed.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Thanks, looks good to me:
Reviewed-by: Gao Xiang <xiang@kernel.org>
Thanks,
Gao Xiang
> ---
> v2: add DBG_BUGON(!raw), a TODO comment.
>
> lib/compress.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/compress.c b/lib/compress.c
> index af0c720..40723a1 100644
> --- a/lib/compress.c
> +++ b/lib/compress.c
> @@ -73,10 +73,11 @@ static void vle_write_indexes(struct z_erofs_vle_compress_ctx *ctx,
>
> di.di_clusterofs = cpu_to_le16(ctx->clusterofs);
>
> - /* whether the tail-end (un)compressed block or not */
> + /* whether the tail-end uncompressed block or not */
> if (!d1) {
> - type = raw ? Z_EROFS_VLE_CLUSTER_TYPE_PLAIN :
> - Z_EROFS_VLE_CLUSTER_TYPE_HEAD;
> + /* TODO: tail-packing inline compressed data */
> + DBG_BUGON(!raw);
> + type = Z_EROFS_VLE_CLUSTER_TYPE_PLAIN;
> advise = cpu_to_le16(type << Z_EROFS_VLE_DI_CLUSTER_TYPE_BIT);
>
> di.di_advise = advise;
> --
> 1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-24 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 6:27 [PATCH v2] erofs-utils: no compression case for tail-end block in vle_write_indexes() Yue Hu
2021-07-24 13:57 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).