From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: "weiyongjun (A)" <weiyongjun1@huawei.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>, Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static
Date: Mon, 9 Aug 2021 11:06:22 +0800 [thread overview]
Message-ID: <YRCbrtHZjo9oZfol@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <82bae76e-8811-22d4-0b75-f58df1153def@huawei.com>
On Mon, Aug 09, 2021 at 10:49:31AM +0800, weiyongjun (A) wrote:
>
> 在 2021/8/9 7:56, Chao Yu 写道:
> > On 2021/8/8 21:19, Gao Xiang wrote:
> > > On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
> > > > The sparse tool complains as follows:
> > > >
> > > > fs/erofs/data.c:150:24: warning:
> > > > symbol 'erofs_iomap_ops' was not declared. Should it be static?
> > > >
> > > > This symbol is not used outside of data.c, so marks it static.
> >
> > Thanks for the patch, I guess it will be better to fix in original patch
> > if you don't mind.
>
>
> Yes, better to fix in original patch.
Ok, I'll merge this into the original patch this tomorrow.
(Anyway, thanks for the report!)
Thanks,
Gao Xiang
>
> Regards.
prev parent reply other threads:[~2021-08-09 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 6:33 [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static Wei Yongjun
2021-08-08 13:19 ` Gao Xiang
2021-08-08 23:56 ` Chao Yu
2021-08-09 2:49 ` weiyongjun (A)
2021-08-09 3:06 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRCbrtHZjo9oZfol@B-P7TQMD6M-0146.local \
--to=hsiangkao@linux.alibaba.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).