From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yue Hu <zbestahu@gmail.com>
Cc: xiang@kernel.org, linux-erofs@lists.ozlabs.org,
huyue2@yulong.com, zbestahu@163.com
Subject: Re: [PATCH] erofs-utils: add clusterofs zero check to write_uncompressed_extent()
Date: Tue, 17 Aug 2021 20:18:31 +0800 [thread overview]
Message-ID: <YRupF5+YgVvBM09n@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <20210817040605.732-1-zbestahu@gmail.com>
On Tue, Aug 17, 2021 at 12:06:04PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> No need to reset clusterofs to 0 if it's already 0. Acturally, we also
> observed that case frequently. Let's avoid it.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
(btw, also, if compression performance is important for some cases, I'd
suggest if someone could take some time on multi-threaded mkfs...
That includes:
- paralleled compression for different files;
- paralleled segment compression for one file (the basic principle is
to deal with a file with sub-files with the same segment size, such
as 16M, like what I described in the following thread:
https://lore.kernel.org/r/20200705182049.GA20632@hsiangkao-HP-ZHAN-66-Pro-G1
That may be quite also useful for LZMA compression later.)
Thanks,
Gao Xiang
next prev parent reply other threads:[~2021-08-17 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 4:06 [PATCH] erofs-utils: add clusterofs zero check to write_uncompressed_extent() Yue Hu
2021-08-17 12:18 ` Gao Xiang [this message]
2021-08-17 13:13 ` Gao Xiang
2021-08-17 14:10 ` Yue Hu
2021-08-17 14:38 ` Gao Xiang
2021-08-18 2:21 ` Yue Hu
2021-08-18 14:06 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRupF5+YgVvBM09n@B-P7TQMD6M-0146.local \
--to=hsiangkao@linux.alibaba.com \
--cc=huyue2@yulong.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).