linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Guo Xuenan <guoxuenan@huawei.com>, mpiglet@outlook.com
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v3 1/5] erofs-utils: introduce dump.erofs
Date: Tue, 28 Sep 2021 10:33:49 +0800	[thread overview]
Message-ID: <YVJ/DVHlUG83A3Jk@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <YU/nRm9ug/kFXHBD@B-P7TQMD6M-0146.local>

Hi,

On Sun, Sep 26, 2021 at 11:21:42AM +0800, Gao Xiang wrote:
> Hi Xuenan and Qi,
> 
> On Wed, Sep 15, 2021 at 05:35:33PM +0800, Guo Xuenan wrote:
> > From: Wang Qi <mpiglet@outlook.com>
> > 
> > Add dump-tool for erofs to facilitate users directly
> > analyzing the erofs image file.
> > 
> > Signed-off-by: Guo Xuenan <guoxuenan@huawei.com>
> > Signed-off-by: Wang Qi <mpiglet@outlook.com>
> 
> I'm almost fine with the series, and I will merge some of the patches
> later.
> 
> Due to busy work, my original plan was to fix some nits by myself and
> apply. Anyway, I will reply some comments this evening...

I've merged the first 2 patches into dev branch with modification (so no
need to resend the first two patches).

The rest patches are still a bit messy, I've set up a new
experimental-dump branch, please check out:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/?h=experimental-dump

There are some stuffs needing to be resolved in advance:
 1) rename all "dumpfs_" prefix into "erofsdump_";
 2) I feel still uncomfortable when reading get_path_by_nid() and
    erofs_read_dir(). Could we refactor them by introducing
    erofs_for_each_dir() or likewise?
 3) file_category_types and the switch in dumpfs_print_inode() are
    duplicated to me. I think one of them can be removed instead.
 4) please help using "filefrag -v -b1" style when printing extent info
    in erofsdump_show_inode_phy(), like below:

 ext:     logical_offset:        physical_offset: length:   expected: flags:
   0:        0..   20479: 21788270592..21788291071:  20480:             last,eof

Thanks,
Gao Xiang


  reply	other threads:[~2021-09-28  2:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:35 [PATCH v3 1/5] erofs-utils: introduce dump.erofs Guo Xuenan
2021-09-15  9:35 ` [PATCH v3 2/5] dump.erofs: add "-s" option to dump superblock information Guo Xuenan
2021-09-15  9:35 ` [PATCH v3 3/5] dump.erofs: add -S options for collecting statistics of the whole filesystem Guo Xuenan
2021-09-15  9:35 ` [PATCH v3 4/5] dump.erofs: add -i options to dump file information of specific inode number Guo Xuenan
2021-09-15  9:35 ` [PATCH v3 5/5] dump.erofs: add -I options to dump the layout of a particular inode on disk Guo Xuenan
2021-09-26  3:21 ` [PATCH v3 1/5] erofs-utils: introduce dump.erofs Gao Xiang
2021-09-28  2:33   ` Gao Xiang [this message]
2021-09-28  6:23     ` Qi Wang
2021-09-28  7:54       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVJ/DVHlUG83A3Jk@B-P7TQMD6M-0146.local \
    --to=hsiangkao@linux.alibaba.com \
    --cc=guoxuenan@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=mpiglet@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).