From: Huang Jianan via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: kernel test robot <lkp@intel.com>, linux-erofs@lists.ozlabs.org
Cc: zhangshiming@oppo.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, yh@oppo.com, guanyuwei@oppo.com,
guoweichao@oppo.com
Subject: Re: [PATCH 2/2] erofs: add sysfs node to control sync decompression strategy
Date: Fri, 12 Nov 2021 10:08:40 +0800 [thread overview]
Message-ID: <b8b71e6c-fbfd-4989-a1e2-15c9ed53f46e@oppo.com> (raw)
In-Reply-To: <202111120433.A7XxZNvu-lkp@intel.com>
在 2021/11/12 4:17, kernel test robot 写道:
> Hi Huang,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on xiang-erofs/dev-test]
> [also build test ERROR on next-20211111]
> [cannot apply to v5.15]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678393057%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=OVZ%2BPtlKYw1zTA3lxF2mFAqcHDs6FjweHQpTpS%2B6uog%3D&reserved=0]
>
> url: https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FHuang-Jianan%2Ferofs-add-sysfs-interface%2F20211109-105542&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678403052%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vvNfYf7RfWT813%2FG%2FOUvTPLOyYqlw1FXQZXjPuqoqsk%3D&reserved=0
> base: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
> config: xtensa-buildonly-randconfig-r004-20211111 (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678403052%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SIkgxAB9wqCI7O0OjvYinNEpFtSD7vUO2YX%2FwQFC480%3D&reserved=0 -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2Fd6bf9edf69e87ee0a9795421ff2e1a9b69a29ce8&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678403052%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BHaZRNBm3bV0VbSMU0vlz6pokoI3tA8kNpVxCGF1wtc%3D&reserved=0
> git remote add linux-review https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678403052%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ICXqRmM2WczvCZQYR9hBUVQddexNDPdhSmr80YLCueY%3D&reserved=0
> git fetch --no-tags linux-review Huang-Jianan/erofs-add-sysfs-interface/20211109-105542
> git checkout d6bf9edf69e87ee0a9795421ff2e1a9b69a29ce8
> # save the attached .config to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from <command-line>:
>>> include/linux/compiler_types.h:140:41: error: 'struct erofs_mount_opts' has no member named 'readahead_sync_decompress'
This problem has been fixed by adding macros in v2.
I will resend a final version of the patch in a clean chain later. 😁
Thanks,
Jianan
> 140 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
> | ^~~~~~~~~~~~~~~~~~
> include/linux/stddef.h:17:33: note: in expansion of macro '__compiler_offsetof'
> 17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
> | ^~~~~~~~~~~~~~~~~~~
> fs/erofs/sysfs.c:42:19: note: in expansion of macro 'offsetof'
> 42 | .offset = offsetof(struct _struct, _name),\
> | ^~~~~~~~
> fs/erofs/sysfs.c:46:9: note: in expansion of macro 'EROFS_ATTR_OFFSET'
> 46 | EROFS_ATTR_OFFSET(_name, 0644, _id, _struct)
> | ^~~~~~~~~~~~~~~~~
> fs/erofs/sysfs.c:55:9: note: in expansion of macro 'EROFS_RW_ATTR'
> 55 | EROFS_RW_ATTR(_name, pointer_bool, _struct)
> | ^~~~~~~~~~~~~
> fs/erofs/sysfs.c:59:1: note: in expansion of macro 'EROFS_RW_ATTR_BOOL'
> 59 | EROFS_RW_ATTR_BOOL(readahead_sync_decompress, erofs_mount_opts);
> | ^~~~~~~~~~~~~~~~~~
>
>
> vim +140 include/linux/compiler_types.h
>
> 71391bdd2e9aab Xiaozhou Liu 2018-12-14 139
> 71391bdd2e9aab Xiaozhou Liu 2018-12-14 @140 #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
> 71391bdd2e9aab Xiaozhou Liu 2018-12-14 141
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7C01%7Chuangjianan%40oppo.com%7C0d3d672ac3e94a90cf9108d9a5505aae%7Cf1905eb1c35341c5951662b4a54b5ee6%7C0%7C0%7C637722589678403052%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I8XIGfml9qKANF9lYjvZ1eRcBGmbE%2BPDSsaajTOgfXo%3D&reserved=0
next prev parent reply other threads:[~2021-11-12 2:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:54 [PATCH 1/2] erofs: add sysfs interface Huang Jianan via Linux-erofs
2021-11-09 2:54 ` [PATCH 2/2] erofs: add sysfs node to control sync decompression strategy Huang Jianan via Linux-erofs
2021-11-09 3:16 ` Gao Xiang
2021-11-09 7:43 ` Huang Jianan via Linux-erofs
2021-11-09 7:45 ` [PATCH v2 1/2] erofs: add sysfs interface Huang Jianan via Linux-erofs
2021-11-09 7:45 ` [PATCH v2 2/2] erofs: add sysfs node to control sync decompression strategy Huang Jianan via Linux-erofs
2021-11-09 13:27 ` Chao Yu
2021-11-09 15:38 ` [PATCH v3 1/2] erofs: add sysfs interface Huang Jianan
2021-11-09 15:38 ` [PATCH v3 2/2] erofs: add sysfs node to control sync decompression strategy Huang Jianan
2021-11-10 3:09 ` [PATCH v3 1/2] erofs: add sysfs interface Chao Yu
2021-11-10 13:48 ` [PATCH v4 " Huang Jianan
2021-11-10 13:48 ` [PATCH v4 2/2] erofs: add sysfs node to control sync decompression strategy Huang Jianan
2021-11-11 2:15 ` Chao Yu
2021-11-09 13:14 ` [PATCH v2 1/2] erofs: add sysfs interface Chao Yu
2021-11-11 20:17 ` [PATCH 2/2] erofs: add sysfs node to control sync decompression strategy kernel test robot
2021-11-12 2:08 ` Huang Jianan via Linux-erofs [this message]
2021-11-09 3:10 ` [PATCH 1/2] erofs: add sysfs interface Gao Xiang
2021-11-09 7:29 ` Huang Jianan via Linux-erofs
2021-11-09 3:14 ` Joe Perches
2021-11-09 7:31 ` Huang Jianan via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b71e6c-fbfd-4989-a1e2-15c9ed53f46e@oppo.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=guanyuwei@oppo.com \
--cc=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=yh@oppo.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).