Linux-EROFS Archive on lore.kernel.org
 help / color / Atom feed
From: Li Guifu <blucerlee@gmail.com>
To: Gao Xiang <gaoxiang25@huawei.com>,
	Pratik Shinde <pratikshinde320@gmail.com>,
	Li Guifu <bluce.liguifu@huawei.com>, Chao Yu <yuchao0@huawei.com>,
	linux-erofs@lists.ozlabs.org
Cc: Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH v9] erofs-utils: support calculating checksum of erofs blocks
Date: Fri, 8 Nov 2019 21:37:13 +0800
Message-ID: <bdd4a875-30fb-3a0c-43b3-270a545a32cf@gmail.com> (raw)
In-Reply-To: <20191030062809.34362-1-gaoxiang25@huawei.com>



On 2019/10/30 14:28, Gao Xiang wrote:
> From: Pratik Shinde <pratikshinde320@gmail.com>
> 
> Added code for calculating crc of erofs blocks (4K size).
> For now it calculates checksum of first block. but it can
> be modified to calculate crc for any no. of blocks.
> 
> Note that the first 1024 bytes are not checksumed to allow
> for the installation of x86 boot sectors and other oddities.
> 
> Fill 'feature_compat' field of erofs_super_block so that it
> can be used on kernel side. also fixing one typo.
> 
> Signed-off-by: Pratik Shinde <pratikshinde320@gmail.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> 
It looks good
Reviewed-by: Li Guifu <blucerlee@gmail.com>

Thanks,

      reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 15:08 [PATCH-v5] erofs-utils:code for calculating crc " Pratik Shinde
2019-10-20  9:06 ` Gao Xiang via Linux-erofs
2019-10-20 14:11 ` Gao Xiang via Linux-erofs
2019-10-23  3:49   ` [PATCH v7] erofs-utils: support calculating " Gao Xiang
2019-10-28 14:23     ` [PATCH v8] " Gao Xiang
2019-10-30  2:39       ` Chao Yu
2019-10-30  2:55         ` Gao Xiang
2019-10-30  6:28           ` [PATCH v9] " Gao Xiang
2019-11-08 13:37             ` Li Guifu [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdd4a875-30fb-3a0c-43b3-270a545a32cf@gmail.com \
    --to=blucerlee@gmail.com \
    --cc=bluce.liguifu@huawei.com \
    --cc=gaoxiang25@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=miaoxie@huawei.com \
    --cc=pratikshinde320@gmail.com \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EROFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-erofs/0 linux-erofs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-erofs linux-erofs/ https://lore.kernel.org/linux-erofs \
		linux-erofs@lists.ozlabs.org linux-erofs@ozlabs.org
	public-inbox-index linux-erofs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linux-erofs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git