From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Hu Weiwen <sehuww@mail.scut.edu.cn>,
Gao Xiang <hsiangkao@redhat.com>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fix mkfs flush inode i_u
Date: Sat, 6 Feb 2021 21:56:25 +0800 [thread overview]
Message-ID: <ec907a7d-ccf8-a5e1-3f34-2249709097cb@aliyun.com> (raw)
In-Reply-To: <20210131094525.168251-1-sehuww@mail.scut.edu.cn>
On 2021/1/31 17:45, Hu Weiwen wrote:
> When choosing which field of i_u to use, it should be `inode->i_mode & S_IFMT'
>
> Previously, the default branch is always taken. Fortunately, all 3 field has
> the same data type, and they are in the same union, so it happens to work.
>
> Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
prev parent reply other threads:[~2021-02-06 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 9:45 [PATCH] erofs-utils: fix mkfs flush inode i_u Hu Weiwen
2021-01-31 10:34 ` Gao Xiang via Linux-erofs
2021-02-06 13:56 ` Li GuiFu via Linux-erofs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec907a7d-ccf8-a5e1-3f34-2249709097cb@aliyun.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=bluce.lee@aliyun.com \
--cc=hsiangkao@redhat.com \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).