Linux-ext4 Archive on lore.kernel.org
 help / color / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: Jonny Grant <jg@jguk.org>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member
Date: Fri, 22 May 2020 23:12:41 -0600
Message-ID: <04681804-F540-48E9-BD4A-79AF89DBC6CA@dilger.ca> (raw)
In-Reply-To: <ad3290d5-86af-99c1-f9d5-cd1bab710429@jguk.org>


[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On May 22, 2020, at 9:09 AM, Jonny Grant <jg@jguk.org> wrote:
> 
> From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <jg@jguk.org>
> Date: Fri, 22 May 2020 16:07:58 +0100
> Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
> 
> Signed-off-by: Jonathan Grant <jg@jguk.org>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index ad2dbf6e4924..7a042896bab7 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
> 	__le32	inode;			/* Inode number */
> 	__le16	rec_len;		/* Directory entry length */
> 	__u8	name_len;		/* Name length */
> -	__u8	file_type;
> +	__u8	file_type;		/* See file type macros EXT4_FT_* below */
> 	char	name[EXT4_NAME_LEN];	/* File name */
> };
> 
> --
> 2.17.1
> 


Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 15:09 Jonny Grant
2020-05-23  5:12 ` Andreas Dilger [this message]
2020-05-29  3:10   ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04681804-F540-48E9-BD4A-79AF89DBC6CA@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=jg@jguk.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ext4 Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ext4/0 linux-ext4/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ext4 linux-ext4/ https://lore.kernel.org/linux-ext4 \
		linux-ext4@vger.kernel.org
	public-inbox-index linux-ext4

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ext4


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git