From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
matthew.weber@rockwellcollins.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2] create_inode: set xattrs to the root directory as well
Date: Thu, 30 Jul 2020 09:27:50 +0200 [thread overview]
Message-ID: <159609406998.3391.5621985067917886015@kwain> (raw)
In-Reply-To: <B2EE7AC5-BEC0-46A8-8C37-D3085645F94C@dilger.ca>
Hello,
Gentle ping. What's the status of this patch?
Thanks!
Antoine
Quoting Andreas Dilger (2020-07-17 13:17:08)
>
> > On Jul 17, 2020, at 4:08 AM, Antoine Tenart <antoine.tenart@bootlin.com> wrote:
> >
> > populate_fs do copy the xattrs for all files and directories, but the
> > root directory is skipped and as a result its extended attributes aren't
> > set. This is an issue when using mkfs to build a full system image that
> > can be used with SElinux in enforcing mode without making any runtime
> > fix at first boot.
> >
> > This patch adds logic to set the root directory's extended attributes.
> >
> > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
>
> > ---
> >
> > Since v1:
> > - Moved the set_inode_xattr logic for the root directory
> > from __populate_fs to populate_fs2.
> >
> > misc/create_inode.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/misc/create_inode.c b/misc/create_inode.c
> > index e8d1df6b55a5..fe66faf1b53d 100644
> > --- a/misc/create_inode.c
> > +++ b/misc/create_inode.c
> > @@ -1050,9 +1050,17 @@ errcode_t populate_fs2(ext2_filsys fs, ext2_ino_t parent_ino,
> > file_info.path_max_len = 255;
> > file_info.path = calloc(file_info.path_max_len, 1);
> >
> > + retval = set_inode_xattr(fs, root, source_dir);
> > + if (retval) {
> > + com_err(__func__, retval,
> > + _("while copying xattrs on root directory"));
> > + goto out;
> > + }
> > +
> > retval = __populate_fs(fs, parent_ino, source_dir, root, &hdlinks,
> > &file_info, fs_callbacks);
> >
> > +out:
> > free(file_info.path);
> > free(hdlinks.hdl);
> > return retval;
> > --
> > 2.26.2
> >
>
>
> Cheers, Andreas
>
>
>
>
>
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-07-30 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 10:08 [PATCH v2] create_inode: set xattrs to the root directory as well Antoine Tenart
2020-07-17 11:17 ` Andreas Dilger
2020-07-30 7:27 ` Antoine Tenart [this message]
2020-09-04 8:23 ` Antoine Tenart
2020-09-04 19:43 ` Andreas Dilger
2020-09-07 7:27 ` Antoine Tenart
2020-12-15 18:38 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159609406998.3391.5621985067917886015@kwain \
--to=antoine.tenart@bootlin.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=matthew.weber@rockwellcollins.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).