From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Boyang Xue <bxue@redhat.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix tune2fs checksum failure for mounted filesystem
Date: Sat, 14 Aug 2021 10:24:29 -0400 [thread overview]
Message-ID: <162895105421.460437.8931255765382647790.b4-ty@mit.edu> (raw)
In-Reply-To: <20210812124737.21981-1-jack@suse.cz>
On Thu, 12 Aug 2021 14:47:37 +0200, Jan Kara wrote:
> Commit 81414b4dd48 ("ext4: remove redundant sb checksum recomputation")
> removed checksum recalculation after updating superblock free space /
> inode counters in ext4_fill_super() based on the fact that we will
> recalculate the checksum on superblock writeout. That is correct
> assumption but until the writeout happens (which can take a long time)
> the checksum is incorrect in the buffer cache and if tune2fs is called
> in that time window it will complain. So return back the checksum
> recalculation and add a comment explaining the tune2fs peculiarity.
>
> [...]
Applied, thanks!
[1/1] ext4: Fix tune2fs checksum failure for mounted filesystem
commit: e905fbe3fd0fdb90052f6efdf88f50a78833cfe7
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2021-08-14 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 12:47 [PATCH] ext4: Fix tune2fs checksum failure for mounted filesystem Jan Kara
2021-08-14 14:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162895105421.460437.8931255765382647790.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=bxue@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).