From: "Theodore Ts'o" <tytso@mit.edu>
To: jack@suse.cz, yangerkun <yangerkun@huawei.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
yukuai3@huawei.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3] ext4: flush s_error_work before journal destroy in ext4_fill_super
Date: Thu, 30 Sep 2021 23:53:16 -0400 [thread overview]
Message-ID: <163306038712.260230.15600354044963943938.b4-ty@mit.edu> (raw)
In-Reply-To: <20210924093917.1953239-1-yangerkun@huawei.com>
On Fri, 24 Sep 2021 17:39:17 +0800, yangerkun wrote:
> The error path in ext4_fill_super forget to flush s_error_work before
> journal destroy, and it may trigger the follow bug since
> flush_stashed_error_work can run concurrently with journal destroy
> without any protection for sbi->s_journal.
>
> [32031.740193] EXT4-fs (loop66): get root inode failed
> [32031.740484] EXT4-fs (loop66): mount failed
> [32031.759805] ------------[ cut here ]------------
> [32031.759807] kernel BUG at fs/jbd2/transaction.c:373!
> [32031.760075] invalid opcode: 0000 [#1] SMP PTI
> [32031.760336] CPU: 5 PID: 1029268 Comm: kworker/5:1 Kdump: loaded
> 4.18.0
> [32031.765112] Call Trace:
> [32031.765375] ? __switch_to_asm+0x35/0x70
> [32031.765635] ? __switch_to_asm+0x41/0x70
> [32031.765893] ? __switch_to_asm+0x35/0x70
> [32031.766148] ? __switch_to_asm+0x41/0x70
> [32031.766405] ? _cond_resched+0x15/0x40
> [32031.766665] jbd2__journal_start+0xf1/0x1f0 [jbd2]
> [32031.766934] jbd2_journal_start+0x19/0x20 [jbd2]
> [32031.767218] flush_stashed_error_work+0x30/0x90 [ext4]
> [32031.767487] process_one_work+0x195/0x390
> [32031.767747] worker_thread+0x30/0x390
> [32031.768007] ? process_one_work+0x390/0x390
> [32031.768265] kthread+0x10d/0x130
> [32031.768521] ? kthread_flush_work_fn+0x10/0x10
> [32031.768778] ret_from_fork+0x35/0x40
>
> [...]
Applied, thanks!
[1/1] ext4: flush s_error_work before journal destroy in ext4_fill_super
commit: 5ded76080628728881a5e6e7d2e06425cfe4ea1a
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2021-10-01 3:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:39 [PATCH v3] ext4: flush s_error_work before journal destroy in ext4_fill_super yangerkun
2021-10-01 3:53 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163306038712.260230.15600354044963943938.b4-ty@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).