From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, cluster-devel@redhat.com,
Steven Whitehouse <swhiteho@redhat.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.de>, Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
Date: Thu, 23 Oct 2014 10:53:50 +0200 [thread overview]
Message-ID: <20141023085349.GA30381@lst.de> (raw)
In-Reply-To: <20141022165150.GA12809@quack.suse.cz>
On Wed, Oct 22, 2014 at 06:51:50PM +0200, Jan Kara wrote:
> So there are two reasons:
> 1) Currently if you call quotactl() with invalid quota type you'll get
> EINVAL. To maintain this with addition of project quotas you need to check
> the types early before calling check_quotactl_permission() and other
> checks.
>
> 2) I didn't want filesystem quotactl callbacks to deal with quota types
> they don't support. Sure each fs could do a type check in the callback but
> this looked easier.
>
> Now I see your point about s_dquot and I can move allowed_types out of
> s_dquot if that makes you happier. But otherwise what I did still seems as
> the best solution to me.
Moving it out of s_dquot seems very sensible to me.
next prev parent reply other threads:[~2014-10-23 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 14:38 [PATCH 0/12 v3] Moving i_dquot out of struct inode Jan Kara
2014-10-21 14:38 ` [PATCH 01/12] quota: Remove const from function declarations Jan Kara
2014-10-21 14:38 ` [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports Jan Kara
2014-10-22 16:29 ` Christoph Hellwig
2014-10-22 16:51 ` Jan Kara
2014-10-23 8:53 ` Christoph Hellwig [this message]
2014-10-21 14:38 ` [PATCH 03/12] gfs2: Set allowed quota types Jan Kara
2014-10-21 14:38 ` [PATCH 04/12] xfs: " Jan Kara
2014-10-21 14:38 ` [PATCH 05/12] quota: Use function to provide i_dquot pointers Jan Kara
2014-10-21 14:38 ` [PATCH 06/12] ext2: Convert to private i_dquot field Jan Kara
2014-10-21 14:38 ` [PATCH 07/12] ext3: " Jan Kara
2014-10-21 14:38 ` [PATCH 08/12] ext4: " Jan Kara
2014-10-21 14:38 ` [PATCH 09/12] ocfs2: " Jan Kara
2014-10-23 10:25 ` Joel Becker
2014-10-23 12:05 ` Jan Kara
2014-10-21 14:38 ` [PATCH 10/12] reiserfs: " Jan Kara
2014-10-21 14:38 ` [PATCH 11/12] jfs: " Jan Kara
2014-10-21 14:38 ` [PATCH 12/12] vfs: Remove i_dquot field from inode Jan Kara
2014-11-04 11:19 [PATCH 0/12 v4] Moving i_dquot out of struct inode Jan Kara
2014-11-04 11:19 ` [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023085349.GA30381@lst.de \
--to=hch@lst.de \
--cc=cluster-devel@redhat.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=jeffm@suse.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).