From: "Theodore Ts'o" <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: darrick.wong@oracle.com, lczerner@redhat.com,
"Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 6/9] e2scrub_all: add the -n option which shows what e2scrub_all would do
Date: Thu, 21 Mar 2019 16:25:10 -0400 [thread overview]
Message-ID: <20190321202513.1969-7-tytso@mit.edu> (raw)
In-Reply-To: <20190321202513.1969-1-tytso@mit.edu>
Also fix the copyright symbol so it is properly formatted when
processed into postscript or pdf.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
scrub/e2scrub_all.8.in | 17 ++++++++++++++---
scrub/e2scrub_all.in | 8 +++++---
2 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/scrub/e2scrub_all.8.in b/scrub/e2scrub_all.8.in
index ba3b8735e..e2cd5e44a 100644
--- a/scrub/e2scrub_all.8.in
+++ b/scrub/e2scrub_all.8.in
@@ -20,12 +20,23 @@ See the
manual page for more information about how the checking is performed.
.SH OPTIONS
.TP
-\fB-A\fR
-Scrub all ext[234] filesystems even if they are not mounted.
+\fB-n\fR
+Print what commands
+.B e2scrub_all
+would execute to initiate the e2scrub operations.
+(Note: these commands will not actually be executed; however, since
+.B e2scrub_all
+needs to run some additional, privileged commands to query the
+system to determine which
+.B e2scrub
+commands would be executed, it still needs to be run as root.)
.TP
\fB-r\fR
Remove e2scrub snapshots but do not check anything.
.TP
+\fB-A\fR
+Scrub all ext[234] filesystems even if they are not mounted.
+.TP
\fB-V\fR
Print version information and exit.
.SH SEE ALSO
@@ -33,4 +44,4 @@ Print version information and exit.
.SH AUTHOR
Darrick J. Wong <darrick.wong@oracle.com>
.SH COPYRIGHT
-Copyright ©2018 Oracle. License is GPLv2+. <http://www.gnu.org/licenses/gpl-2.0.html>
+Copyright \[co]2018 Oracle. License is GPLv2+. <http://www.gnu.org/licenses/gpl-2.0.html>
diff --git a/scrub/e2scrub_all.in b/scrub/e2scrub_all.in
index d725a7f2e..8bc868aa0 100644
--- a/scrub/e2scrub_all.in
+++ b/scrub/e2scrub_all.in
@@ -29,8 +29,9 @@ scrub_args=""
print_help() {
echo "Usage: $0 [OPTIONS]"
- echo " -A: Scrub all ext[234] filesystems even if not mounted."
+ echo " -n: Show what commands e2scrub_all would execute."
echo " -r: Remove e2scrub snapshots."
+ echo " -A: Scrub all ext[234] filesystems even if not mounted."
echo " -V: Print version information and exit."
}
@@ -60,10 +61,11 @@ exitcode() {
exit "${ret}"
}
-while getopts "ArV" opt; do
+while getopts "nrAV" opt; do
case "${opt}" in
- "A") scrub_all=1;;
+ "n") DBG="echo Would execute: " ;;
"r") scrub_args="${scrub_args} -r";;
+ "A") scrub_all=1;;
"V") print_version; exitcode 0;;
*) print_help; exitcode 2;;
esac
--
2.19.1
next prev parent reply other threads:[~2019-03-21 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 20:25 [PATCH -v2 0/9] e2fsprogs: e2scrub cleanups Theodore Ts'o
2019-03-21 20:25 ` [PATCH 1/9] e2scrub: check to make sure lvm2 is installed Theodore Ts'o
2019-03-21 20:25 ` [PATCH 2/9] debian: drop lvm2 from the recommends line Theodore Ts'o
2019-03-21 20:25 ` [PATCH 3/9] Fix "make install-strip" Theodore Ts'o
2019-03-21 20:25 ` [PATCH 4/9] e2scrub: fix up "make install-strip" support Theodore Ts'o
2019-03-21 20:25 ` [PATCH 5/9] e2scrub: add the -n option which shows what commands e2scrub would execute Theodore Ts'o
2019-03-21 20:25 ` Theodore Ts'o [this message]
2019-03-21 20:25 ` [PATCH 7/9] e2scrub_all: make sure there's enough free space for a snapshot Theodore Ts'o
2019-03-21 20:25 ` [PATCH 8/9] e2scrub_all: refactor device probe loop Theodore Ts'o
2019-03-21 20:55 ` Lukas Czerner
2019-03-21 20:25 ` [PATCH 9/9] e2scrub,e2scrub_all: print a (more understandable) error if not run as root Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2019-03-21 2:02 [PATCH 1/9] e2scrub: check to make sure lvm2 is installed Theodore Ts'o
2019-03-21 2:02 ` [PATCH 6/9] e2scrub_all: add the -n option which shows what e2scrub_all would do Theodore Ts'o
2019-03-21 4:01 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321202513.1969-7-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).