From: Jan Kara <jack@suse.cz>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 23/30] ext2: Use kmemdup rather than duplicating its implementation
Date: Wed, 3 Jul 2019 16:24:57 +0200 [thread overview]
Message-ID: <20190703142457.GA26423@quack2.suse.cz> (raw)
In-Reply-To: <20190703131727.25735-1-huangfq.daxian@gmail.com>
On Wed 03-07-19 21:17:27, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Thanks. Added to my tree.
Honza
> ---
> fs/ext2/xattr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 1e33e0ac8cf1..a9c641cd5484 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -506,11 +506,10 @@ bad_block: ext2_error(sb, "ext2_xattr_set",
>
> unlock_buffer(bh);
> ea_bdebug(bh, "cloning");
> - header = kmalloc(bh->b_size, GFP_KERNEL);
> + header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
> error = -ENOMEM;
> if (header == NULL)
> goto cleanup;
> - memcpy(header, HDR(bh), bh->b_size);
> header->h_refcount = cpu_to_le32(1);
>
> offset = (char *)here - bh->b_data;
> --
> 2.11.0
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-07-03 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 13:17 [PATCH 23/30] ext2: Use kmemdup rather than duplicating its implementation Fuqian Huang
2019-07-03 14:24 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703142457.GA26423@quack2.suse.cz \
--to=jack@suse.cz \
--cc=huangfq.daxian@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).