From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA0DC48BE3 for ; Sun, 7 Jul 2019 18:47:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AB842082E for ; Sun, 7 Jul 2019 18:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbfGGSrs (ORCPT ); Sun, 7 Jul 2019 14:47:48 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:46070 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726418AbfGGSrr (ORCPT ); Sun, 7 Jul 2019 14:47:47 -0400 Received: from callcc.thunk.org (75-104-86-74.mobility.exede.net [75.104.86.74] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x67IlCEX014297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 7 Jul 2019 14:47:19 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id C12BE42002E; Sun, 7 Jul 2019 14:47:11 -0400 (EDT) Date: Sun, 7 Jul 2019 14:47:11 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Chandan Rajendra , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Linus Torvalds Subject: Re: [PATCH v6 13/17] fs-verity: support builtin file signatures Message-ID: <20190707184711.GB19775@mit.edu> References: <20190701153237.1777-1-ebiggers@kernel.org> <20190701153237.1777-14-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701153237.1777-14-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jul 01, 2019 at 08:32:33AM -0700, Eric Biggers wrote: > From: Eric Biggers > > To meet some users' needs, add optional support for having fs-verity > handle a portion of the authentication policy in the kernel. An > ".fs-verity" keyring is created to which X.509 certificates can be > added; then a sysctl 'fs.verity.require_signatures' can be set to cause > the kernel to enforce that all fs-verity files contain a signature of > their file measurement by a key in this keyring. > > See the "Built-in signature verification" section of > Documentation/filesystems/fsverity.rst for the full documentation. > > Signed-off-by: Eric Biggers Looks good, you can add: Reviewed-by: Theodore Ts'o