From: Dave Chinner <david@fromorbit.com>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Joseph Qi <jiangqi903@gmail.com>, Theodore Ts'o <tytso@mit.edu>,
Jan Kara <jack@suse.cz>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
Liu Bo <bo.liu@linux.alibaba.com>
Subject: Re: [RFC] performance regression with "ext4: Allow parallel DIO reads"
Date: Mon, 29 Jul 2019 08:51:22 +1000 [thread overview]
Message-ID: <20190728225122.GG7777@dread.disaster.area> (raw)
In-Reply-To: <15112e38-94fe-39d6-a8e2-064ff47187d5@linux.alibaba.com>
On Fri, Jul 26, 2019 at 09:12:07AM +0800, Joseph Qi wrote:
>
>
> On 19/7/26 05:20, Andreas Dilger wrote:
> >
> >> On Jul 23, 2019, at 5:17 AM, Joseph Qi <jiangqi903@gmail.com> wrote:
> >>
> >> Hi Ted & Jan,
> >> Could you please give your valuable comments?
> >
> > It seems like the original patches should be reverted? There is no data
>
> From my test result, yes.
> I've also tested libaio with iodepth 16, it behaves the same. Here is the test
> data for libaio 4k randrw:
>
> -------------------------------------------------------------------------------------------
> w/ parallel dio reads | READ 78313KB/s, 19578, 1698.70us | WRITE 78313KB/s, 19578, 4837.60us
> -------------------------------------------------------------------------------------------
> w/o parallel dio reads| READ 387774KB/s, 96943, 1009.73us | WRITE 387656KB/s，96914, 308.87us
> -------------------------------------------------------------------------------------------
>
> Since this commit went into upstream long time ago，to be precise, Linux
> 4.9, I wonder if someone else has also observed this regression, or
> anything I missed?
I suspect that the second part of this set of mods that Jan had
planned to do (on the write side to use shared locking as well)
did not happen and so the DIO writes are serialising the workload.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-07-28 22:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 9:22 [RFC] performance regression with "ext4: Allow parallel DIO reads" Joseph Qi
2019-07-23 11:17 ` Joseph Qi
2019-07-25 21:20 ` Andreas Dilger
2019-07-26 1:12 ` Joseph Qi
2019-07-27 1:57 ` Andreas Dilger
2019-07-27 2:16 ` Joseph Qi
2019-07-28 22:51 ` Dave Chinner [this message]
2019-07-30 1:34 ` Joseph Qi
2019-08-15 15:13 ` Jan Kara
2019-08-16 13:23 ` Joseph Qi
2019-08-16 14:57 ` Jan Kara
2019-08-20 3:00 ` Joseph Qi
2019-08-20 16:08 ` Theodore Y. Ts'o
2019-08-21 1:04 ` Joseph Qi
2019-08-21 3:34 ` Theodore Y. Ts'o
2019-08-22 6:45 ` Joseph Qi
2019-08-22 5:40 ` Dave Chinner
2019-08-23 7:57 ` Joseph Qi
2019-08-23 8:07 ` Joseph Qi
2019-08-23 10:16 ` Dave Chinner
2019-08-23 13:08 ` Joseph Qi
2019-08-24 2:18 ` Dave Chinner
2019-08-26 8:39 ` Jan Kara
2019-08-26 19:10 ` Andreas Dilger
2019-08-27 1:00 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728225122.GG7777@dread.disaster.area \
--to=david@fromorbit.com \
--cc=adilger@dilger.ca \
--cc=bo.liu@linux.alibaba.com \
--cc=jack@suse.cz \
--cc=jiangqi903@gmail.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoguang.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).