From: Jonathan Corbet <corbet@lwn.net>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ayush Ranjan <ayushr2@illinois.edu>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-doc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Ext4 documentation fixes.
Date: Sat, 24 Aug 2019 15:24:53 -0600 [thread overview]
Message-ID: <20190824152453.03737143@lwn.net> (raw)
In-Reply-To: <DEDD6BA5-6E18-4ED6-9EF6-E11EDA593700@dilger.ca>
On Thu, 15 Aug 2019 09:16:23 -0700
Andreas Dilger <adilger@dilger.ca> wrote:
> On Aug 15, 2019, at 09:11, Ayush Ranjan <ayushr2@illinois.edu> wrote:
> >
> > This commit aims to fix the following issues in ext4 documentation:
> > - Flexible block group docs said that the aim was to group block
> > metadata together instead of block group metadata.
> > - The documentation consistly uses "location" instead of "block number".
> > It is easy to confuse location to be an absolute offset on disk. Added
> > a line to clarify all location values are in terms of block numbers.
> > - Dirent2 docs said that the rec_len field is shortened instead of the
> > name_len field.
> > - Typo in bg_checksum description.
> > - Inode size is 160 bytes now, and hence i_extra_isize is now 32.
> > - Cluster size formula was incorrect, it did not include the +10 to
> > s_log_cluster_size value.
> > - Typo: there were two s_wtime_hi in the superblock struct.
> > - Superblock struct was outdated, added the new fields which were part
> > of s_reserved earlier.
> > - Multiple mount protection seems to be implemented in fs/ext4/mmp.c.
> >
> > Signed-off-by: Ayush Ranjan <ayushr2@illinois.edu>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
I've applied this to the docs tree.
However, Ayush: the patch was rather badly corrupted by your mail client.
I managed to fix it up, but please in the future verify that you can email
a patch to yourself and apply it before submitting it. There may be some
useful hints in Documentation/process/email-clients.rst .
Thanks,
jon
next prev parent reply other threads:[~2019-08-24 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+UE=SPyMXZUhHFm0KgvihPdaE=yH5ra6n1C4XhKgM6aGheo=A@mail.gmail.com>
2019-08-23 3:18 ` [PATCH v2] Ext4 documentation fixes Theodore Y. Ts'o
[not found] ` <71dfe444-3efb-5f1c-d8a1-bb0e98002fd1@mixmax.com>
2019-08-23 14:16 ` Theodore Y. Ts'o
[not found] ` <DEDD6BA5-6E18-4ED6-9EF6-E11EDA593700@dilger.ca>
2019-08-24 21:24 ` Jonathan Corbet [this message]
2019-08-24 23:09 ` Theodore Y. Ts'o
2019-08-25 14:42 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824152453.03737143@lwn.net \
--to=corbet@lwn.net \
--cc=adilger.kernel@dilger.ca \
--cc=adilger@dilger.ca \
--cc=ayushr2@illinois.edu \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).