From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Guo <guoyang2@huawei.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH v2] ext4: use percpu_counters for extent_status cache hits/misses
Date: Wed, 28 Aug 2019 11:20:23 -0400 [thread overview]
Message-ID: <20190828152023.GG24857@mit.edu> (raw)
In-Reply-To: <1566983957-6608-1-git-send-email-zhangshaokun@hisilicon.com>
On Wed, Aug 28, 2019 at 05:19:17PM +0800, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@huawei.com>
>
> @es_stats_cache_hits and @es_stats_cache_misses are accessed frequently in
> ext4_es_lookup_extent function, it would influence the ext4 read/write
> performance in NUMA system. Let's optimize it using percpu_counter,
> it is profitable for the performance.
>
> The test command is as below:
> fio -name=randwrite -numjobs=8 -filename=/mnt/test1 -rw=randwrite
> -ioengine=libaio -direct=1 -iodepth=64 -sync=0 -norandommap
> -group_reporting -runtime=120 -time_based -bs=4k -size=5G
>
> And the result is better 10% than the initial implement:
> without the patch，IOPS=197k, BW=770MiB/s (808MB/s)(90.3GiB/120002msec)
> with the patch, IOPS=218k, BW=852MiB/s (894MB/s)(99.9GiB/120002msec)
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Signed-off-by: Yang Guo <guoyang2@huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2019-08-28 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:19 [PATCH v2] ext4: use percpu_counters for extent_status cache hits/misses Shaokun Zhang
2019-08-28 15:20 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828152023.GG24857@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=ebiggers@kernel.org \
--cc=guoyang2@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).